Node.js error handling

Question

I am building an app using node.js and knex for the ORM. I want my insert command to send either a success or error response, but it is not working for some reason:

knex('reports').insert({
    reportid: reportId,
    created_at: currentDate 
}).then().catch(function(error) {
    if(error) {
        console.log("error!!!: " + error)
        res.send(400, error);
    } else {
        console.log('no error');
        res.send(200);
    }
});

The code as is does NOT console.log out the error nor lack of error.

Note - the res.send(200) should go back to my client side to alert the client the request was successful.

Can someone help? Thanks in advance!!

i see.. aside from .catch what else can I use to get the desired effect? — Trung Tran
– Trung Tran, Commented Jan 8, 2016 at 16:44

xaviert · Accepted Answer · 2016-01-09 11:46:14Z

2

Promises will either trigger your then function or the catch function. Not both. Handling the success case happens in the then function, handling the error case happens in the catch function.

To demonstrate with your code:

knex('reports').insert({
    reportid: reportId,
    created_at: currentDate 
}).then(function(data) {
    console.log('no error');
    res.send(200);
}).catch(function(error) {
    console.log("error!!!: " + error)
    res.send(400, error);
});

answered Jan 9, 2016 at 11:46

xaviert

5,9606 gold badges31 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Yonatan · Accepted Answer · 2016-05-09 18:12:48Z

0

You should handle the positive flow within the .then part:

then()
{
        console.log('no error');
        res.send(200);
    }

Also it's not consider a good practice to mix DB code with HTTP related logic as they probably should reside in different layers/components, see best practice number 4 here: http://goldbergyoni.com/checklist-best-practices-of-node-js-error-handling/

answered May 9, 2016 at 18:12

Yonatan

1,8561 gold badge14 silver badges7 bronze badges

Collectives™ on Stack Overflow

Node.js error handling

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related