c++ initialize non pointer object again

Question

In my header file I have:

class Game
{
private:
    string _name;
    Level _currentLevel;
public:
    Game();
    ~Game();
    void setName();
    void run();
};

In my cpp file I have my run function:

void Game::run()
{

    bool finished = false;
    string input;
    while (!finished)
    {
        // get input
        std::cout << "Enter a command: \n";
        std::getline(std::cin, input);
        if (input == "quit")
        {
            finished = true;
        }
        else if (input == "new")
        {
            Level _currentLevel;
        }
        else if (input == "print")
        {
            _currentLevel.printMap();
        }
        else
        {
            std::cout << "Unknown command! \n";
        }


    }
}

constructor and printmap method of Level

Level::Level()
{
    _width = RandomGenerator::Instance()->getRandom(6, 10);
    _height = RandomGenerator::Instance()->getRandom(6, 10);
    for (int y = 0; y < _height; y++)
    {
        for (int x = 0; x < _width; x++)
        {
            addRoom(x, y);
        }
    }
}

void Level::printMap()
{
    for (int y = 0; y < _height; y++)
    {
        for (int x = 0; x < _width; x++)
        {
            if (x != 0)
                cout << " - ";
            cout  << _map[coordinate(x, y)].getSize();
        }
        cout << "\n";
    }
}

However when I type new, that runs Level _currentLevel; (to create a new non pointer object), the object dosnt change. I can see it dosn't change the values of level when I run printmap (which prints a map with 30 random values created in the Level constructor). While debugging the value of _height changes in the Level constructor. How should the value of _currentLevel be updated from my Game class?

I think you swapped 'cpp' and 'header' in your question, didn't you? — martijnn2008
– martijnn2008, Commented Jan 9, 2016 at 23:45
You've misunderstood the article you've linked if you actually have your cpp and header files arranged this way. — Donnie
– Donnie, Commented Jan 10, 2016 at 15:51

Donnie · Accepted Answer · 2016-01-09 23:51:01Z

3

Your new block creates a local stack variable that happens to have the same name as your instance variable (_currentLevel). It does not overwrite the instance variable, and that's why nothing changes.

You have a few straightforward choices:

Use a pointer. I suggest using a shared_ptr so you don't have to worry about deallocating memory on your own.
Extend Level to have an Initialize function. The constructor can call this, or you can call it from other code later if you want to re-initialize an existing variable.
Copy a new local variable to the instance variable.

Personally, I'd suggest the pointer, but either works.

edited Jan 9, 2016 at 23:51

answered Jan 9, 2016 at 23:42

Donnie

47k10 gold badges67 silver badges88 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Sven van den Boogaart Over a year ago

Thanks you pointed out what i did wrong, create two values witht the same name. I solved it now by "Level newLevel; _currentLevel = newLevel;" I should try avoiding pointers as suggested here right ? stackoverflow.com/a/22146244/1667868

Pete Becker Over a year ago

Does a shard_ptr deal with fragmented memory? (Sorry, couldn't resist; wonderful typo!)

Donnie Over a year ago

If _currentLevel lives in this object, and will never get stored outside of it, what you're doing is probably ok. Note that your current fix copies the local into the object (and then you destroy the local when it goes out of scope). if at some point in the future you need to pass _currentLevel out, with your current implementation you'd only be able to pass out a copy safely.

m_pOatrix Over a year ago

@Sven B Avoiding pointers at all cost is like fearing your own shadow. Pointers are an amazing tool and very useful. Learning how and when to use them is a better approach than thinking that you have to avoid them. They are your friends, not your enemies.

bgarcia · Accepted Answer · 2016-01-09 23:50:33Z

0

For starters the prototypes should be in the header and the implementation in the source file. Apart from that, in game::run you declare a second local _currentlevel which shadows the class variable. Outside the constructor, you never modify the class field.

Replace the shadowing line with this->_currentlevel = Level();

answered Jan 9, 2016 at 23:50

bgarcia

1546 bronze badges

Collectives™ on Stack Overflow

c++ initialize non pointer object again

2 Answers 2

4 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related