Best way to check object/variable type in Java

Question

I have many types of activity's, but if at a certain point activity is a TaskComplianceActivity then I want to handle it in a special way.

I could do:

if (activity.getClass().getName() == "au.net.example.myapp.TaskComplianceActivity")

But that is very ugly.

I have tried this, but it didn't work:

if (activity instanceof TaskComplianceActivity)

Does anyone have any suggestions on how I can cleanly do this?

The first way wouldn´t work, since you don´t compare strings that way. The second way with instanecof would also include a null check — SomeJavaGuy
– SomeJavaGuy, Commented Jan 12, 2016 at 8:12
If I step through the code I see: Incompatible conditional operand types Activity and TaskComplianceActivity TaskComplianceActivity cannot be resolved to a type — b85411
– b85411, Commented Jan 12, 2016 at 8:15
Testing the instance is in most cases bad smelling code. If it is possible to do the special handling right in TaskComplianceActivity this would be the prefered solution - just a thought... — treeno
– treeno, Commented Jan 12, 2016 at 8:16
"Incompatible conditional operand types" sounds like a compile error, so how can you "step through the code" if the code doesn't compile? — Andreas
– Andreas, Commented Jan 12, 2016 at 8:39

Geeky Singh · Accepted Answer · 2016-01-12 08:14:41Z

4

Try this:

if (activity.getClass().getName().equals(TaskComplianceActivity.class.getName()))

or this:

if (activity.getClass().getSimpleName().equals(TaskComplianceActivity.class.getSimpleName()))

edited Jan 12, 2016 at 8:14

answered Jan 12, 2016 at 8:12

Geeky Singh

1,0139 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

jmcg Over a year ago

i didnt downvote, but obviously because you dont compare strings that way.

b85411 Over a year ago

I get the error "TaskComplianceActivity cannot be resolved to a type" when I try your second one with getSimpleName(). It definitely exists though! What am I doing wrong?

Collectives™ on Stack Overflow

Best way to check object/variable type in Java

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related