foreach loop issue

Question

branch is of checkbox list type, but while looping through this it adds only one item while i want to store all "li" in branch_id and want to retrive later why it's not adding all in branch_is. is there any other option which can add all this to variable branch_id.

          foreach (ListItem li in branch.Items) 
                {
                    if(li.Selected)
                    {

                        List<int> branch_id = new List<int>();
                        branch_id.Add(Convert.ToInt32(li.Value));

                    }
                }

Arsen Mkrtchyan · Accepted Answer · 2010-08-16 05:11:26Z

1

Try this one

List<int> branch_id = new List<int>();
foreach (ListItem li in branch.Items) 
{
     if(li.Selected)
     {
          branch_id.Add(Convert.ToInt32(li.Value));
     }
}

Or this one if you are using .Net 3.5 or higher and can use LINQ

List<int> branch_id = branch.Items.Where(li=>li.Selected).Select(li=>li.Value).ToList();

answered Aug 16, 2010 at 5:11

Arsen Mkrtchyan

50.9k33 gold badges155 silver badges187 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

NoviceToDotNet Over a year ago

oh my god every time a new object was creating that's y

anishMarokey · Accepted Answer · 2010-08-16 05:14:09Z

you no need for initializing the List<int> branch_id = new List<int>(); again.

If you initialize it will create a new instance for the branch_id and clear all the present value.

foreach (ListItem li in branch.Items) 
                {
                    if(li.Selected)
                    {

                        List<int> branch_id = new List<int>(); // during each time it loops it create new memory and you can't save all the values
                        branch_id.Add(Convert.ToInt32(li.Value));

                    }
                }



so do 

List<int> branch_id = new List<int>(); 
foreach (ListItem li in branch.Items) 
                {
                    if(li.Selected)
                    {


                        branch_id.Add(Convert.ToInt32(li.Value));

                    }
                }

kbrimington · Accepted Answer · 2010-08-16 05:16:56Z

0

I once wrote about an extension method that allows me to simplify the selection with LINQ:

var branch_id = branch.Items.WhereSelected().Select(i => Convert.ToInt32(i.Value)).ToList()

answered Aug 16, 2010 at 5:16

kbrimington

25.7k5 gold badges67 silver badges75 bronze badges

1 Comment

NoviceToDotNet Over a year ago

i am using 2.o thats y it doesn't work in that i think. Well yours answer is of a great help as well. thanks

Collectives™ on Stack Overflow

foreach loop issue

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related