Url.Action generates a wrong url

Question

I use the Url.Action method to generate a Url string.

Thats the result:

"/Home/GetRejectTest/0?IsSelected=False"

The controller and action name are correct but the query parameters are screwed up. Is this because The action does not have a RouteAttribute thus query parameters are generated?

My action:

   public ActionResult GetRejectTest(Test test)
        {
            return new EmptyResult();

        }

Test class has those 3 properties Id, Name, IsSelected.

My route definition:

 routes.MapRoute(
                name: "Default",
                url: "{controller}/{action}/{id}",
                defaults: new { controller = "Home", action = "Index", id = UrlParameter.Optional }
            );

Show the action method signature and the relevant registered routes — haim770
– haim770, Commented Jan 20, 2016 at 20:52
what is values ?. From your screenshot, it looks like the dictionary has 0 and null values for Name and Id. So whatever you are getting is the expected result. Isn't it ? — Shyju
– Shyju, Commented Jan 20, 2016 at 21:05
Assuming values is a new default instance of Test, (and your using the Default route {controller}/{action}/{id}), then the url is correct — user3559349
– user3559349, Commented Jan 20, 2016 at 21:14

Nick Cox · Accepted Answer · 2021-01-22 03:30:20Z

5

The url your generating (/Home/GetRejectTest/0?IsSelected=False) is correct for your route definition. You passing a new instance of Test to the Url.Action() method, which

Internally builds a dictionary based on the name and value (using.ToString()) of each property in your model - i.e. controller=Home, action=GetRejectTest, id=0, Name=null, IsSelected=False
Then searches your route definitions for a match which it finds (url: "{controller}/{action}/{id}") and updates the placeholders (which at this point generates /Home/GetRejectTest/0) but your route definition does not have url parameters for Name and IsSelected so these are added as query string parameters (because Name is null, a query string for that propery is not generated) so the result is now /Home/GetRejectTest/0?IsSelected=False

You have not indicated what result you're actually expecting, but creating specific route definitions will solve most cases. For example if you want

/Home/GetRejectTest/0/false

or /Home/GetRejectTest/0/false/someName if the value of Name is not null, then you can create an additional route (which must be before the default route)

routes.MapRoute(
  name: "Test",
  url: "Home/GetRejectTest/{id}/{isselected}/{name}",
  defaults: new { controller = "Home", action = "GetRejectTest", name = UrlParameter.Optional }
);

Note that because Name is typeof string and therefore can be null, the {name} placeholder needs be the last one and marked as UrlParameter.Optional (otherwise it will revert back to using query string parameters)

edited Jan 22, 2021 at 3:30

Nick Cox

6,5422 gold badges26 silver badges32 bronze badges

answered Jan 21, 2016 at 3:14

user3559349

Sign up to request clarification or add additional context in comments.

1 Comment

Pascal Over a year ago

Ok now I understand it. That I used id as query param in myself was just stupid then ;-) Thanks for your reasonable explanation.

Collectives™ on Stack Overflow

Url.Action generates a wrong url

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related