Issue with retaining loop variable value

Question

I have an error in this piece of code where I have declared public class variable mCountryCode as String.

 for (mCountryCode : isoCountryCodes) {
     locale = new Locale("", mCountryCode);
     if(locale.getDisplayCountry().equals(mSpinner.getSelectedItem())) {
         mCountryCode = locale.getCountry();                        
         break;
     }
 }

If I use for (String mCountryCode : isoCountryCodes) instead then the error will go away but I am not able to sustain the mCountryCode string value after break; line.

Jon Skeet · Accepted Answer · 2016-01-21 19:05:04Z

6

Yup, the enhanced for statement just doesn't work like that. It always declares a new variable.

You can use:

for (String tmp : isoCountryCodes) {
    mCountryCode = tmp;
    ...
}

... although frankly that's a pretty odd thing to do. It seems to me that you don't really want to assign every value to mCountryCode, but only the matching one:

for (String candidate : isoCountryCodes) {
    Locale locale = new Locale("", candidate);
    if (locale.getDisplayCountry().equals(mSpinner.getSelectedItem())) {
        mCountryCode = candidate;
        break;
    }
}

Note that this doesn't assign to an existing locale variable, but declares a new one in each iteration. That's almost certainly a better idea... you can always assign to a field in the if statement if you need to.

answered Jan 21, 2016 at 19:05

Jon Skeet

1.5m893 gold badges9.3k silver badges9.3k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jonas Czech · Accepted Answer · 2016-01-21 19:09:18Z

2

You're not using the enhanced for loop correctly: you need to specify the type, like this:

for (String countryCode : isoCountryCodes) {
     ...
}

Now you can use yourcountryCode string in your loop as needed.

answered Jan 21, 2016 at 19:09

Jonas Czech

12.4k7 gold badges46 silver badges67 bronze badges

Comments

meda · Accepted Answer · 2016-01-21 19:05:11Z

0

It would be better to use a local variable in your foreach

for (String code : isoCountryCodes) {
     locale = new Locale("", code);
     if(locale.getDisplayCountry().equals(mSpinner.getSelectedItem())){
        mCountryCode = locale.getCountry();                        
        break;
     }
 }

answered Jan 21, 2016 at 19:05

meda

45.5k14 gold badges97 silver badges123 bronze badges

Comments

TheoKanning · Accepted Answer · 2016-01-21 19:07:54Z

0

If you want to use mCountryCode outside of the loop, you must declare it before the loop

String mCountryCode = null;
for(int i = 0; i < isoCountryCodes.length(); i++){
    locale = new Locale("", isoCountryCodes[i]);

    if(locale.getDisplayCountry().equals(mSpinner.getSelectedItem())){
        mCountryCode = locale.getCountry();                        
        break;
    }
}

//mCountryCode is still assigned

answered Jan 21, 2016 at 19:07

TheoKanning

1,63912 silver badges20 bronze badges

Collectives™ on Stack Overflow

Issue with retaining loop variable value

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related