Redirect in javascript function, coeigniter

Question

I have the following function that will show a pop up message, once the user click ok it will navigate the user to the controller called backendBanner and call the function delete_banner.

The link written in html and php looks something like this:

<a href="<?php echo base_url().'backendBanner/delete_banner/'.$banner['banner_path']; ?>">

Code for the button in view to call the function

<td>
      <a onclick="return remove_image($(this));" rel="<?php echo $banner['banner_path']; ?>"><input type="button" class="btn btn-danger" value="Delete"></a>
</td>

Code for the function In this function, $banner['banner_path'] is equal to fullpath

<script>
        function remove_image(img)
        {
            if(confirm('<?php echo lang('confirm_remove_image');?>'))
            {
                var fullpath  = img.attr('rel');
                alert(fullpath);
                redirect(base_url()."backendBanner/delete_banner/"+fullpath);
            }
        }
    </script>

How should I go about bringing the user to the link through the function?

how are you currently calling the remove_image() function? — CodeGodie
– CodeGodie, Commented Jan 22, 2016 at 14:42
It should be window.location="<?php echo base_url().'backendBanner/delete_banner/'.$banner['banner_path']; ?>" + fullpath — Vicky Gonsalves
– Vicky Gonsalves, Commented Jan 22, 2016 at 14:42
Always use a console when you're working with clientside code, it will tell you if you're using an undefined function. — Glubus
– Glubus, Commented Jan 22, 2016 at 14:47
you are vulnerable to JS injection attacks. don't echo out arbitrary text from PHP into a JS context. if your translation of confirm_remove_image contains ANY quote characters you'll be introducing a JS syntax error and killing the entire <script> block. always output text into JS via json_encode(). — Marc B
– Marc B, Commented Jan 22, 2016 at 14:49

Vicky Gonsalves · Accepted Answer · 2016-01-22 15:25:55Z

1

It should be :

window.location="<?php echo base_url().'backendBanner/delete_banner/'.$banner['banner_path']; ?>" + fullpath

answered Jan 22, 2016 at 15:25

Vicky Gonsalves

11.8k3 gold badges39 silver badges58 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

beny lim Over a year ago

Can u also help me with another problem that I am facing? The value of fullpath is dynamic it can be in the following format "assets/images/banner3.jpg" and "banner4.jpg". The problem I am facing is that, when the fullpath is "assets/images/banner3.jpg" and I var_dump the value of $image_name in the delete_banner controller, it only returns "assets" instead of "assets/images/banner3.jpg".

Vicky Gonsalves Over a year ago

try var_dump($banner) and check ?

beny lim Over a year ago

the value is pass over through "fullpath"

Vicky Gonsalves Over a year ago

Can you create php fiddle?

beny lim Over a year ago

When i var_dump(fullpath) it is "assets/images/banner3.jpg"

|

CodeGodie · Accepted Answer · 2016-01-22 14:44:46Z

1

The problem in your JS code is that you're using redirect(). This will not work because redirect() is a PHP/Codeigniter function, not JS.

Use window.location instead.

answered Jan 22, 2016 at 14:44

CodeGodie

12.2k6 gold badges40 silver badges66 bronze badges

Comments

gustavonecore · Accepted Answer · 2016-01-22 15:04:34Z

1

Assuming that the function base_url() it's a valid function created by you...

Try with:

location.href = base_url() + img.attr('rel');

Note: Try to use some templating engine like twig, blade etc.

answered Jan 22, 2016 at 15:04

gustavonecore

235 bronze badges

Collectives™ on Stack Overflow

Redirect in javascript function, coeigniter

3 Answers 3

6 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

6 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related