Recursive jquery ajax

Question

I want my function to process the results, then call itself from the done callback.

function geocode(id) {
    console.log(id + ' geocode');
    $.ajax({
        url: '/customers/' + id + '/geocode',
        dataType: 'json',
        data: {
            id: id,
        }
    }).done(function() {
        var newID = id++;
        console.log(id + ' done.');
        geocode(newID);
    });
}

This isn't incrementing though, say if I start it at 1, it just loops on 2 forever. I know it's a pain returning data from ajax, but I've never fully got my head round the nuances

what do you exactly want? you want response from the ajax request..? — Rajesh kannan
– Rajesh kannan, Commented Jan 25, 2016 at 13:44

Rory McCrossan · Accepted Answer · 2016-01-25 13:47:35Z

3

You need to increment the variable before you set it to the value of newId:

function geocode(id) {
    console.log(id + ' geocode');
    $.ajax({
        url: '/customers/' + id + '/geocode',
        dataType: 'json',
        data: {
            id: id,
        }
    }).done(function() {
        console.log(id + ' done.'); // show this before incrementing
        var newID = ++id; // note the operator order here
        geocode(newID);
    });
}

Working example

edited Jan 25, 2016 at 13:47

answered Jan 25, 2016 at 13:42

Rory McCrossan

338k41 gold badges322 silver badges353 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

mplungjan Over a year ago

Does he not need a context?

Rory McCrossan Over a year ago

Possibly, depending on the scope of id and it's use elsewhere in code that isn't shown here.

A. Wolff Over a year ago

@mplungjan Why, the correct context is set as i can see it

Tom Over a year ago

This works perfectly. I need to look into the operators a bit more, I didn't realise there would be a difference between i++ and ++i

A. Wolff Over a year ago

console.log(id + ' done.'); should be set before pre incrementation to get older value

|

Kristoffer K · Accepted Answer · 2016-01-25 13:42:46Z

-1

Your id will be 1 on the first iteration, and 1 on the second (and third, fourth etc.) iteration as well as you never update it's value.

Try this:

function geocode(id) {
    console.log(id + ' geocode');
    $.ajax({
        url: '/customers/' + id + '/geocode',
        dataType: 'json',
        data: {
            id: id,
        }
    }).done(function() {
        id = id++;
        console.log(id + ' done.');
        geocode(id);
    });
}

answered Jan 25, 2016 at 13:42

Kristoffer K

2,05318 silver badges23 bronze badges

1 Comment

Rory McCrossan Over a year ago

This is logically the same as what the OP currently has.

Collectives™ on Stack Overflow

Recursive jquery ajax

2 Answers 2

7 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

7 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related