Why doesn't Javascript let me close up my function?

Question

I dunno guys, this is a really weird one, but I might just be making a simple mistake and not even realizing it.

I'm sort of a newbie to Javascript, so I'm attempting to write a script that gets content from a PHP script (which returns only a number) and write that data to a div... but Javascript had other ideas. I'm testing on Chrome on Mac OS X, although it doesn't work on Safari either.

The following block is giving me problems:

function getContent() {
 window.setInterval(function () {
  $.get("get.php", function (data) {
   $('#img').slideUp();
   $('#div').html(data);
   $('#div').slideDown();
  }
 }
}

Which is failing with:

Uncaught SyntaxError: Unexpected token }

on line 51, or line 8, for the purposes of this example.

Does anyone know why it would fail like this? Don't I need to close the brackets I open?

IMHO Your indentation is too small, making it difficult to notice the obvious missing ) char. I prefer to indent it to at least two spaces. But that is just me. — Rosdi Kasim
– Rosdi Kasim, Commented Aug 17, 2010 at 5:46

Kobi · Accepted Answer · 2010-08-17 05:43:46Z

10

Your curly braces are OK, but you're missing a few parentheses:

function getContent() {
 window.setInterval(function () {
  $.get("get.php", function (data) {
   $('#img').slideUp();
   $('#div').html(data);
   $('#div').slideDown();
  }); //get - end statement
 }, 4000); // setInterval - need another parameter, end statement
}

answered Aug 17, 2010 at 5:43

Kobi

139k41 gold badges259 silver badges302 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Matthew Flaschen · Accepted Answer · 2010-08-17 05:49:52Z

4

You're not closing the parentheses for your function calls. As Kobi said, you also need a third parameter for setInterval.

function getContent() {
 window.setInterval(function () {
  $.get("get.php", function (data) {
   $('#img').slideUp();
   $('#div').html(data);
   $('#div').slideDown();
  });
 }, 1000);
}

edited Aug 17, 2010 at 5:49

answered Aug 17, 2010 at 5:43

Matthew Flaschen

286k53 gold badges523 silver badges554 bronze badges

Comments

naikus · Accepted Answer · 2010-08-17 14:38:06Z

3

The window.setInterval function has a following syntax:

window.setInterval(functionRef, timeout);

In your case the setInterval and $.get() function call are missing the closing parentheses ). It would be clear for you to write this in the following way:

function getContent() {
  // success handler
  var success = function() {
    // declare the function first as "changeUI"
    var changeUI = function() {
      $('#img').slideUp();
      $('#div').html(data);
      $('#div').slideDown();
    };
    // call the setInterval passing the function
    window.setInterval(changeUI, 2000);
  };

  // get the resource and call the "success" function on successful response
  $.get("get.php", success);
}

edited Aug 17, 2010 at 14:38

answered Aug 17, 2010 at 5:52

naikus

24.5k4 gold badges45 silver badges44 bronze badges

Comments

Scott M. · Accepted Answer · 2010-08-17 05:43:22Z

0

your window.setInterval is missing a ) after the } on the second to last line

answered Aug 17, 2010 at 5:43

Scott M.

7,34732 silver badges39 bronze badges

Collectives™ on Stack Overflow

Why doesn't Javascript let me close up my function?

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related