MySQL "UPDATE" not working?

Question

So I have the following code, I have made sure that both the variables have something stored in them, by echoing the results in both $lat and $long

    $lat = $latitude;
    $updatelat = mysql_query("UPDATE listings SET lat='". $lat ."' WHERE id='". $id ."'");
    $long = $longitude;
    $updatelong = mysql_query("UPDATE listings SET long='". $long ."' WHERE id='". $id ."'");

The $updatelat query works absolutely perfect, and the value is set in the database.

The $updatelong query however doesn't work, but there is definitely a value stored in $long

Can anyone see something obviously wrong with this code? There is definitely a column called long in my database. I am completely confused.

I don't have that to hand. The 'lat' and 'long' columns are both TEXT. — nulled
– nulled, Commented Jan 27, 2016 at 17:05
sienote: stop using deprecated mysql_* functions! and start using pdo or mysqli to have a higher security (better prevention to sqlinjections) — davejal
– davejal, Commented Jan 27, 2016 at 17:05
What's the value in $long? You might have an escaping issue. — Darwin von Corax
– Darwin von Corax, Commented Jan 27, 2016 at 17:08
You can avoid escaping/quoting/etc. issues by using prepared statements, although that would mean you'd have to stop using the mysql_* api (which you should do anyway because it's deprecated in PHP5 and gone from PHP7. ;) ) — Darwin von Corax
– Darwin von Corax, Commented Jan 27, 2016 at 17:17

P. Jairaj · Accepted Answer · 2016-01-27 17:13:18Z

1

Why 2 queries? You can do it in one as the id is same.

$lat = $latitude;
$long = $longitude;
$updatelatlong = mysqli_query($connection, "UPDATE listings SET lat='". $lat ."',long='". $long ."' WHERE id='". $id ."'");

answered Jan 27, 2016 at 17:13

P. Jairaj

1,0331 gold badge6 silver badges8 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jorel Amthor · Accepted Answer · 2016-01-27 17:07:02Z

0

Do you do this $result = mysqli_query($con,$updatelong); ? It'd be helpfull to see more of your code than this little part

answered Jan 27, 2016 at 17:07

Jorel Amthor

1,2941 gold badge14 silver badges39 bronze badges

Comments

nulled · Accepted Answer · 2016-02-01 21:35:40Z

0

Simple fix for this

If queries such as this don't work:

$updatelat = mysql_query("UPDATE listings SET lat='". $lat ."' WHERE id='". $id ."'");

There is probably a clash with MySQL reserved keywords, so try using backticks

$updatelat = mysql_query("UPDATE listings SET `lat`='". $lat ."' WHERE `id`='". $id ."'");

and it works!

edited Feb 1, 2016 at 21:35

answered Jan 29, 2016 at 10:10

nulled

4231 gold badge6 silver badges20 bronze badges

Collectives™ on Stack Overflow

MySQL "UPDATE" not working?

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related