For loop is only posting first 3 elements of array - PHP

Question

I have arrays which can potentially have unlimited amount of elements in them. I am trying to input them into my db but it only inputs the first 3 elements of the arrays. My arrays looks like this

array(4) {
  ["ID"]=>
  array(5) {
    [0]=>
    string(1) "1"
    [1]=>
    string(1) "2"
    [2]=>
    string(1) "3"
    [3]=>
    string(1) "4"
    [4]=>
    string(1) "5"
  }
  ["firstname"]=>
  array(5) {
    [0]=>
    string(5) "Steve"
    [1]=>
    string(3) "Dan"
    [2]=>
    string(3) "Jim"
    [3]=>
    string(4) "Adam"
    [4]=>
    string(5) "James"
  }
  ["surname"]=>
  array(5) {
    [0]=>
    string(5) "Smith"
    [1]=>
    string(6) "Colins"
    [2]=>
    string(6) "Knight"
    [3]=>
    string(5) "Lamar"
    [4]=>
    string(4) "Rays"
  }
  ["submit"]=>
  string(5) "Enter"
}

this is my for loop and sql statement

$a[0] = $_SESSION['ID'];
$a[1] = $_SESSION['firstname'];
$a[2] = $_SESSION['surname'];


 for ($i = 0; $i<count($a); ++$i){
     $id = $_SESSION['ID'][$i];
     $fname = $_SESSION['firstname'][$i];
     $sname = $_SESSION['surname'][$i];

$query = "INSERT INTO orders(id, firstname, surname) VALUES('$id', '$fname', '$sname')";


if (mysqli_query($connection, $query)) {
echo "New record created successfully";
} else {
echo "Error: " . $query . "<br>" . mysqli_error($connection);
}
}

this will only post the 0,1,2 elements of each array. How can I change it so it insert all elements to my db?

You are looping through $a, which only has 3 visible entries. Not sure where else it's supposed to get rows from to insert. — Andrew Coder
– Andrew Coder, Commented Jan 29, 2016 at 23:58
What's the purpose of the $a array? Other than the erroneous count($a), you're never using it for anything. — Barmar
– Barmar, Commented Jan 30, 2016 at 1:02

Martin Heralecký · Accepted Answer · 2016-02-01 09:59:43Z

2

for ($i = 0; $i<count($a); ++$i)

This cycle will go three times because $a array has 3 items (ID, firstname, surname). Change count($a) to count($a[0]) and it should work. Although this isn't exactly the best solution (what if one of those three arrays has more/less items than the others?...)

edited Feb 1, 2016 at 9:59

answered Jan 30, 2016 at 0:00

Martin Heralecký

5,8194 gold badges32 silver badges68 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

SnowmanPusha Over a year ago

Thank you this should work because all arrays will have the same amount of elements

Martin Heralecký Over a year ago

How can you be so sure? I suppose the array is input from a form. What if someone changes the form and sends with some inputs missing? You should count on this...

Hyper codes · Accepted Answer · 2016-01-30 00:12:21Z

1

you are looping through $a array has 3 items

try this solution

$a[0] = $_SESSION['ID'];
$a[1] = $_SESSION['firstname'];
$a[2] = $_SESSION['surname'];

$b = count($a[0]);

 for ($i = 0; $i<$b; ++$i){
     $id = $_SESSION['ID'][$i];
     $fname = $_SESSION['firstname'][$i];
     $sname = $_SESSION['surname'][$i];

$query = "INSERT INTO orders(id, firstname, surname) VALUES('$id', '$fname', '$sname')";


if (mysqli_query($connection, $query)) {
echo "New record created successfully";
} else {
echo "Error: " . $query . "<br>" . mysqli_error($connection);
}
}

answered Jan 30, 2016 at 0:12

Hyper codes

869 bronze badges

Collectives™ on Stack Overflow

For loop is only posting first 3 elements of array - PHP

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related