Change value when click a button

Question

I have a code that increases a variable "money" when I press the key "S" and I would like to change the value when I press a button but it doesnt work.

Thanks.

Increases the "money":

document.addEventListener('keydown', function(event) {
console.log("Event");
if(event.keyCode == 83) {
console.log("Key Pressed");
document.getElementById("key").innerHTML = "<img src=\"stick2.gif\">";
shoot -= 1;
document.getElementById("shoot").innerHTML = shoot;
if(shoot > 0){
money += 4;
document.getElementById("money").innerHTML = money;
document.getElementById("cash").innerHTML = "<img src=\"money.png\">";
    }
  }
}

Changes the value:

    function onClick12()   {
    document.getElementById("ak").innerHTML = "<img src=\"ak/ak1.png\">";
    document.getElementById('b1').disable = true;
    if(event.keyCode == 83 && shoot > 0) {
    money += 8;
    document.getElementById("money").innerHTML = money;
    document.getElementById("cash").innerHTML = "<img src=\"money.png\">";
      }
    }
    function onClick13()   {
    document.getElementById("ak").innerHTML = "<img src=\"ak/ak4.png\">";
    document.getElementById('b4').disable = true;
    if(event.keyCode == 83 && shoot > 0) {
    money += 12;
    document.getElementById("money").innerHTML = money;
    document.getElementById("cash").innerHTML = "<img src=\"money.png\">";
        }
      }

Buttons:

<input type="button" onclick="onClick12()" id="b1" value="Use">
<input type="button" onclick="onClick13()" id="b4" value="Use">

You wish to change the money variable ? Can you try replacing the functions names : function onClick13(event) {...} function onClick12(event) {...} — Rigin
– Rigin, Commented Feb 2, 2016 at 10:28
I think i got a mistake - You are clicking a button right, WHY you need event.keyCode in that button click ? You could have removed this check right? — Rigin
– Rigin, Commented Feb 2, 2016 at 10:36

Walfrat · Accepted Answer · 2016-02-02 10:47:25Z

1

if(event.keyCode == 83 && shoot > 0)

The variable event is not defined in the scope of you function onClick12/13 Note that if you still get the event datas from the onclick event you won't have a keycode since click event don't embbed keybaord information.

But do you really want your user to press a key and click for what you want ? If so i suggest you to have catch a keydown event to register in a variable the key currently pressed and a keyup event to reset that value.

That variable should be defined outside the function so the other function can access it. Here is the basic stuff

var key83Pressed = false;
document.addEventListener('keydown', function(event) {
    key83Pressed = event.keyCode == 83;


}
function onCLick12(){
    if(key83Pressed){

    }
} 
document.addEventListener('keyup', function(event){

    if(event.keyCode==83){
          key83Pressed  = false;
    }

});

edited Feb 2, 2016 at 10:47

answered Feb 2, 2016 at 10:24

Walfrat

5,3941 gold badge18 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Pedro D. Over a year ago

If I make an other keydown event inside onClick function will it work

Walfrat Over a year ago

Nope this isn't how it works. that means that every time you will click you will bind a new listener listening for key events. This means that this won't work until you have click at least once on the button and you will have a memory leak.

Collectives™ on Stack Overflow

Change value when click a button

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related