Catching Exception with JUnit

Question

I am writing a JUnit test case for a method and to enhance my Cobertura branch coverage I want to catch the exception but not sure why the test doesn't catch the exception.

Method to be tested:

 public void getCondition( Map<String, Message> messagesMap ) throws EISClientException
{
    Message message = containsAMessageCode(getMessageCodes(), messagesMap);
    if(message!=null)
    {
        throw new EISClientException("One of the specified message code matched returned errors." + 
                message.getMessageCode() + ": " + message.getMessageType() + ": " + message.getMessageText());

    }
}

JUnit test:

@Test
public void testgetCondition() throws Exception {
    boolean caughtException = false;
    try {
        clientResponse = mock(ClientResponse.class);
        RetrieveBillingServiceResponse response = new RetrieveBillingServiceResponse();

        MessageToExceptionPostProcessFilter postProcessFilter = new MessageToExceptionPostProcessFilter();
        postProcessFilter.setCondition(ConditionOperator.OR);

        Message message = new Message();
        message.setMessageCode("200");
        message.setMessageType(MessageTypeEnum.MESSAGE_TYPE_INFO);
        message.setMessageText("Service completed successfully");

        response.setMessages(Arrays.asList(message));

        Map<String, Message> map = new HashMap<String, Message>();
        map.put("test", message);

        RetrieveBillingServiceResponse serviceResponse = postProcessFilter.getCondition(map);

    } catch (EISClientException ex) {
        caughtException = true;
        assertEquals("One of the specified message code matched returned errors.", ex.getMessage());
    }
    assertTrue(caughtException);
}

If the message is not null it should catch the exception but it is not. Am I doing anything wrong?

Thanks,

I corrected my code. I got two similar methods and posted the wrong one. — user5192032
– user5192032, Commented Feb 3, 2016 at 22:18

Kevin Hooke · Accepted Answer · 2016-02-03 22:23:44Z

1

Another way of testing the expected exception was thrown is to have a fail() after the line of code under test that causes the exception.

If the exception is thrown you jump to your catch and the fail() is never called, if no exception is thrown the fail() executes following the line that should have thrown an exception and your test fails.

Also, look at your current assertEquals() - the String you are comparing with is not the same as the String you are building when you create the Exception.

answered Feb 3, 2016 at 22:23

Kevin Hooke

2,6312 gold badges20 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Vishal Gokhale · Accepted Answer · 2016-02-03 22:21:09Z

0

@yole is right. you haven't called the method under test.
a better way to achieve the same thing would be to use the @Test(expected = .class) annotation - of course - you won't be able to check for the message. But in your case the method under test is throwing just one exception - So as long as you are testing that it throws that exception - it should be fine. Needless to say cobertura - will be happy ! here's a tutorial: http://www.mkyong.com/unittest/junit-4-tutorial-2-expected-exception-test/

answered Feb 3, 2016 at 22:21

Vishal Gokhale

811 silver badge7 bronze badges

2 Comments

Gavin Over a year ago

You should never use @ExpectException in my professional opinion, you should catch the exception and check the cause and message or as you expect. Just my professional opinion. :)

Jean-François Savard Over a year ago

@Gavin ExpectedException have an expectMessage function.

Vika Marquez · Accepted Answer · 2016-02-03 22:29:43Z

0

Are you sure that your test somewhere call getCondition() method? I don't see it from your code. But if you sure that getCondition() was called, try to use !message.isEmpty() instead of message!=null

answered Feb 3, 2016 at 22:29

Vika Marquez

3531 gold badge3 silver badges12 bronze badges

2 Comments

user5192032 Over a year ago

I call it in RetrieveBillingServiceResponse serviceResponse = postProcessFilter.getCondition(map);

Vika Marquez Over a year ago

Oh, yes, I see now. What about using !message.isEmpty() instead of message!=null in getCondition() method? Didn't help? Or your Message object haven't this method (isEmpty)? If have, I think the problem may be here, because checking for null and checking for empty is not the same.

AlinG · Accepted Answer · 2016-02-03 22:35:57Z

0

There are a couple of things that are not OK here:

Use correct annotation for this kind of test

@Test(expected = EISClientException.class)
It is a bad practice to have multiple asserts in a unit test. See 1 - that should fix it.
What about containsAMessageCode(getMessageCodes(), messagesMap); . Are you sure this is not returning null ? If you really want to unit test getCondition method you should short-circuit that call.
The assertEquals in catch (EISClientException ex) { ... } doesn't seem OK. You are throwing an exception with a more complicated message, it would never be true as your code looks like now.

answered Feb 3, 2016 at 22:35

AlinG

4913 silver badges13 bronze badges

Collectives™ on Stack Overflow

Catching Exception with JUnit

4 Answers 4

Comments

2 Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

2 Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related