Setting *.prototype methods inside angular factory not working

Question

I'm creating an angular factory that encapsulates and injectable type that can be new-ed up as such:

(function() {
angular
  .module('app')
  .factory('PaymentStream', [

function() {

    function PaymentStream(){

        this._endingBalance = null;
    }

    PaymentStream.prototype.serialize = function() {

        // method body here
    };

    return PaymentStream;

   }]);
})();

When I create a PaymentStream via new PaymentStream() only the constructor seems to have been called. If I don't use prototype and just define the methods inside the constructor it works but then I'm redefining the functions with each instance.

Any idea why those prototypes are not being set?

Edit

Here is how it is being used in the outside.

    function addStreamFunctions(stream) {

        angular.merge(stream, new PaymentStream());
    }

I don't see anything wrong with your code, maybe the way you are using the factory outside is the problem? can you show how you use it from a controller or something? — Louie Almeda
– Louie Almeda, Commented Feb 5, 2016 at 4:41

Louie Almeda · Accepted Answer · 2016-02-06 11:13:25Z

1

So basing on your edit, The factory was indeed working correctly. The problem is the way you used it, you angular.merged the newed object with another object, so its type is not a PaymentStream anymore, the resulting object became a 'generic' object

If the stream is a plain object, what you can do is pass the stream variable in the constructor of PaymentStream and do the merging manually inside your constructor function. Something like

function PaymentStream(stream){

    this._endingBalance = null;

    var keys = Object.keys(stream); //get all properties from the stream

    keys.forEach(function(key){
       this[key] = stream[key];   //put each one in the instance of your object;
    });

}

then use it like

function addStreamFunctions(stream) {

    var stream = new PaymentStream(stream);

}

this code is untested, please tell me if it worked or not :)

edited Feb 6, 2016 at 11:13

answered Feb 6, 2016 at 11:06

Louie Almeda

5,67035 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Arun P Johny · Accepted Answer · 2016-02-05 04:28:52Z

0

Since you are working with factory you need to return an instance of the object, in this case a new instance of PaymentStream

(function() {
  angular.module('my-app').factory('PaymentStream', [function() {
    function PaymentStream() {
      this._endingBalance = null;
    }

    PaymentStream.prototype.serialize = function() {
      // method body here
    };

    return new PaymentStream();
  }]);
})();

answered Feb 5, 2016 at 4:28

Arun P Johny

389k68 gold badges532 silver badges532 bronze badges

4 Comments

Louie Almeda Over a year ago

I think he wants the class to be returned by the factory, not an instance

Arun P Johny Over a year ago

@LouieAlmeda jsfiddle.net/arunpjohny/pad6zsvp/3 - In that case OP's code should just work

Louie Almeda Over a year ago

Yes it does, I don't see anything wrong about the code either, maybe we're looking at the wrong portion of the code

Brian Triplett Over a year ago

@LouieAlmeda - that's exactly right, I'm looking to take the factory and use it o new up classes

Collectives™ on Stack Overflow

Setting *.prototype methods inside angular factory not working

2 Answers 2

Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related