PHP function to check if 2 variables are empty

Question

I have an index page, I want it to include a page called splash.php and not display.php when a user lands on index.php, but once a user does something (sets a variable) ie if a user searches (variable "query") i want it to include display.php and not include splash.php

What is wrong with this code?

function hasGet()
{
    return !empty($_GET['fact']);
    return !empty($_POST['query']);
}

if (hasGet()) {
    include("display.php");
}

else {
    include("splash.php");
}

This question should be removed

Will do, but what if i don't get a good answer

Dasa
– Dasa

2010-08-19 18:05:48 +00:00
Commented Aug 19, 2010 at 18:05 — Dasa
– Dasa, Commented Aug 19, 2010 at 18:05
You accept an answer if you think it solved your problem.

NullUserException
– NullUserException

2010-08-19 19:02:36 +00:00
Commented Aug 19, 2010 at 19:02 — NullUserException
– NullUserException, Commented Aug 19, 2010 at 19:02

Community · Accepted Answer · 2020-06-20 09:12:55Z

5

Only the first return statement is executed. Try:

return !empty($_GET['fact']) && !empty($_POST['query']);

A better way to accomplish what you are trying to do is use sessions.

index.php

<?php

session_start();

if (!isset($_SESSION['visited'])) {
    $_SESSION['visited'] = true;
    include 'splash.php';
} else {
    include 'display.php';
}

?>

This way after a user visits index.php for the first time, $_SESSION['visited'] is set to true and it won't show the splash page throughout their visit.

edited Jun 20, 2020 at 9:12

CommunityBot

11 silver badge

answered Aug 19, 2010 at 17:39

NullUserException

85.8k31 gold badges212 silver badges239 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

NullUserException Over a year ago

@Dasa What does your form/url look like?

NullUserException Over a year ago

@Dasa That means $_GET['fact'] is empty, the function returns false, and thus it should include spash.php. Is that not happening?

CogitoErgoSum · Accepted Answer · 2010-08-19 17:39:10Z

2

You cannot have two returns as you are doing. Try

return (!empty($_GET['fact']) && !empty($_GET['query']));

answered Aug 19, 2010 at 17:39

CogitoErgoSum

2,9275 gold badges34 silver badges46 bronze badges

4 Comments

NullUserException Over a year ago

Nice nickname :) And we've got both answer in on the same second... LOL

CogitoErgoSum Over a year ago

Ty. How come you didn't use parenthesis around your entire return statement?

Brendan Long Over a year ago

the parenthesis are unnecessary.

CogitoErgoSum Over a year ago

@Brendan Long, in this particular case you are correct however I would be for future proofing in case a more complex set of logic is put in to determine a true false rather then putting them in later on.

Dejan Marjanović · Accepted Answer · 2010-08-19 19:27:40Z

0

You might want to try this...

if($_SERVER["SCRIPT_NAME"] == "/index.php"){
    include("splash.php");
}else{
    include("display.php");
}

2.

if(!empty($_GET["fact"]) || !empty($_POST["query"])){
    include("display.php");
}else{
    include("splash.php");
}

edited Aug 19, 2010 at 19:27

answered Aug 19, 2010 at 18:18

Dejan Marjanović

19.4k7 gold badges54 silver badges67 bronze badges

1 Comment

Dejan Marjanović Over a year ago

I'm sure it works, but second one will probably produce result that you want. Your situation is confusing.

Collectives™ on Stack Overflow

PHP function to check if 2 variables are empty

3 Answers 3

index.php

2 Comments

4 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

index.php

2 Comments

4 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related