if no row return then it's false when using php with mysql

Question

I noticed that a lot of tutorial instructions often have this code:

$sql="SELECT * from table";
$num=mysql_num_rows();

if ($num > 0)
{
do something
}

Why do they have to use that condition "if ($num > 0)" when I write this code that I think is compact and readable:

$sql="SELECT * from table";
$itExists=mysql_num_rows();

if ($itExists)
{
do something
}

does mysql_num_rows ever return a negative integer? Doesn't PHP always equate 0 to false? I've used this approach and noticed nothing different or unusual.

Timwi · Accepted Answer · 2010-08-21 06:03:52Z

3

Tutorials probably try to make the code as clear, intuitive and explicit as possible. Using mysql_num_rows, whose name clearly implies an integer, as a boolean, is somewhat counter-intuitive. The comparison with zero is implicit. By contrast, if it is perceived as a number, then checking that it’s greater than zero is intuitive and obvious and therefore less confusing.

answered Aug 21, 2010 at 6:03

Timwi

66.8k34 gold badges172 silver badges235 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Sam Becker · Accepted Answer · 2010-08-21 06:09:55Z

2

Why would you assign the number of rows returned to a variable with a bool name like itExists? By doing this you are making information that could be used later less useful. It's better to assign the number of rows (mysql_num_rows()) to a variable that says it holds a number of rows (numRows or in this case num).

Having something like itExists assigned to 4, 5 or 6 isn't good practice. It's in this way that the first method is better.

$pages = $numRows / $itemsPerPage;
//works better than...
$pages = $itExists / $itemsPerPage;

edited Aug 21, 2010 at 6:09

answered Aug 21, 2010 at 6:02

Sam Becker

19.7k14 gold badges63 silver badges81 bronze badges

Comments

Delan Azabani · Accepted Answer · 2010-08-21 05:59:25Z

1

Both ways work just fine. I don't know why you wouldn't choose the second method.

answered Aug 21, 2010 at 5:59

Delan Azabani

81.8k30 gold badges174 silver badges215 bronze badges

Comments

tc. · Accepted Answer · 2010-08-21 06:10:20Z

0

According to http://php.net/manual/en/function.mysql-num-rows.php, it returns FALSE on an error. I'm pretty sure FALSE > 0 is FALSE, so the two are equivalent.

OTOH, it's traditional in other languages (and possibly in older versions of PHP) to return negative numbers on an error. Some OpenSSL signature-verification functions return 1 for "valid", 0 for "invalid", and -1 for "error". It's a coding style thing.

answered Aug 21, 2010 at 6:10

tc.

33.6k5 gold badges80 silver badges98 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 10:32:42Z

0

PD. If you only need to check if there are rows, using mysql_num_rows is not very efficient, it is better to count within the SQL statement:

SELECT COUNT(*) FROM table

See: - MySQL PHP count(*) returning something weird - https://stackoverflow.com/search?q=php+mysql+count+rows

Doesn't PHP always equate 0 to false?

Not always:

$a = 0;
if (!$a) echo 'pass <br />'; else echo 'fails <br />';
if ($a == false) echo 'pass <br />'; else echo 'fails <br />';
if ($a === false) echo 'pass <br />'; else echo 'fails <br />';

See: http://php.net/manual/en/language.operators.comparison.php

edited May 23, 2017 at 10:32

CommunityBot

11 silver badge

answered Aug 21, 2010 at 6:49

Luistar15

1,7493 gold badges14 silver badges16 bronze badges

Collectives™ on Stack Overflow

if no row return then it's false when using php with mysql

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related