Factory function not returning data

Question

I have an angularjs factory to get data via $http.get():

'use strict';
app.factory('apiService', ['$http', function ($http) {
    var apiService = {};
    apiService.urlBase = 'http://localhost:1337/api/';
    apiService.get = function (urlExtension) {
        $http({
            method: 'GET',
            url: apiService.urlBase + urlExtension
        }).then(function successCallback(response) {
            return response.data;
        }, function errorCallback(response) {
            console.log(response);
        });
    }

    return apiService;
}]);

The problem is, that it always returns undefined when i call the method apiService.get(); in a Controller. When I log the response data in the factory, it display the right data. The apiService.urlBase variable is always filled in my controller.

Do you guys have any suggestions or am I doing something wrong? Maybe it's a syntax error.

adam0101 · Accepted Answer · 2016-02-16 18:25:14Z

1

You are not returning the promise that is returned by $http. Add return before $http

answered Feb 16, 2016 at 18:25

adam0101

31.5k22 gold badges102 silver badges193 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

FKutsche Over a year ago

yeah okay, this kind of works, but now i get a $$state object, do you have any suggestions on how to handle that?

FKutsche · Accepted Answer · 2016-02-16 19:16:17Z

0

Okay I solved the problem. I just passed a callback function via parameter for my get() function.

'use strict';
app.factory('apiService', ['$http', function ($http) {
    var apiService = {};
    apiService.urlBase = 'http://localhost:1337/api/';
    apiService.get = function (urlExtension, callback) {
        var data = {};

        $http({
            method: 'GET',
            url: apiService.urlBase + urlExtension
        }).then(function successCallback(response) {
            data = response.data;
            callback(data);
        }, function errorCallback(response) {
            console.log(response);
        });

        return data;
    }

    return apiService;
}]);

answered Feb 16, 2016 at 19:16

FKutsche

4023 silver badges18 bronze badges

Collectives™ on Stack Overflow

Factory function not returning data

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related