C# Override OnActionExecutingAsync Web API call

Question

I'm trying to implement some logging around my web api calls. Nothing too fancy, but I'm still learning async/await and would like the logging to happen without disrupting performance.

Here's an example of what I'd like to implement, just not totally sure how to do it.

public class Logging : ActionFilterAttribute
{
    public override async Task OnActionExecutingAsync(HttpActionContext actionContext, CancellationToken cancellationToken)
    {
        // DoLoggingHere();   ????
        base.OnActionExecutingAsync(actionContext, cancellationToken);
        // OrDoLoggingHere();  ????

        // Also, what does the return look like if any?
    }

    public override Task OnActionExecutedAsync(HttpActionExecutedContext actionExecutedContext, CancellationToken cancellationToken)
    {
        // This method should/could complete before the logging completes.
        base.OnActionExecutedAsync(actionExecutedContext, cancellationToken);

        // Might log here too.
    }
}

Basically I don't want any of my logging to get in the way of the HTTP call. It should be transparent.

Looking for any help!

Possible duplicate of How and When to use `async` and `await` — Liam
– Liam, Commented Mar 19, 2018 at 16:14

Ehsan Sajjad · Accepted Answer · 2016-03-02 15:53:25Z

2

You can await the call, so that thread is returned to pool for more incoming requests and then do logging after the call completes:

var result = await base.OnActionExecutingAsync(actionContext, cancellationToken);
// logging code here

return result;

answered Mar 2, 2016 at 15:53

Ehsan Sajjad

62.6k16 gold badges113 silver badges171 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Richard.Davenport Over a year ago

Could base.OnActionExecutedAsync() be called before my logging finishes?

Ehsan Sajjad Over a year ago

your logging will be done after OnActionExecuting returns some result back, as we are awaiting it, and yes it will complete before OnActionExecuted gets called

Richard.Davenport Over a year ago

I'm asking for the opposite. I would like to see OnActionExecuted be called first, then my logging.

Ehsan Sajjad Over a year ago

then you have to await base.OnActionExecuted and after that logging code to be executed

gandalf Over a year ago

await base.OnActionExecutingAsync(actionContext, cancellationToken); returns a void, cannot get the result like this var result = ...

Collectives™ on Stack Overflow

C# Override OnActionExecutingAsync Web API call

1 Answer 1

5 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related