Having trouble inserting new objects into an embedded array

Question

I'm new to Mongodb and I've been having hell of a time trying to get embedded array working. On insert, I'm able to insert the first element of the array without a problem. However when I update, it keeps throwing an error that '0 is not an Object', which is vague for a error message. What can I do to fix it?

Here are my schema:

FightCards.schema = new SimpleSchema({
    event_id: {
        type: Number
    },
    player_id: {
        type: String
    },
    fighters: {
        type: [Object]
    },
    'fighters.$.id': {
        type: Number
    },
    'fighters.$.name': {
        type: String
    },
    'fighters.$.salary': {
        type: Number
    }
});

Here is the offending code:

 if(FightCards.find({}).count() == 0) {
            FightCards.insert(
                {event_id: this.props.event_id, player_id: Meteor.userId(), fighters: [ {id: fighter.id, name: fighter.first_name + " " + fighter.last_name, salary: salary} ]}, 
                (err, res) => {
                    if(err) console.log(err);
                }
            );
} else {
            FightCards.update({event_id: this.props.event_id, player_id: Meteor.userId()},
                { $push: { fighters: [{id: fighter.id, name: fighter.first_name + " " + fighter.last_name, salary: salary}]}},
                (err, res) => {
                    if(err) console.log(err);
                }
            );
}

Michel Floyd · Accepted Answer · 2016-03-07 01:14:42Z

2

You're trying to push an array onto an array, you only need to push the element. Change:

{ $push: { fighters: [{ id: fighter.id, name: fighter.first_name + " " +
  fighter.last_name, salary: salary }]}},

to

{ $push: { fighters: { id: fighter.id, name: fighter.first_name + " " +
  fighter.last_name, salary: salary }}},

Also you can simplify your code by setting up the query once since $push will create the array if it doesn't yet exist:

let query = {
  event_id: this.props.event_id,
  player_id: Meteor.userId()},
  { $push: { fighters: {
    id: fighter.id,
    name: fighter.first_name + " " + fighter.last_name,
    salary: salary
  }}
};

if( FightCards.find({}).count() ) {
  FightCards.update(query,(err, res) => {
    if(err) console.log(err);
  });
} else {
  FightCards.insert(query,(err, res) => {
    if(err) console.log(err);
  });
}

edited Mar 7, 2016 at 1:14

answered Mar 6, 2016 at 22:21

Michel Floyd

20.3k4 gold badges27 silver badges45 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Craig Over a year ago

Thanks for the help, that fixed it.

Collectives™ on Stack Overflow

Having trouble inserting new objects into an embedded array

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related