PHP Returning value from If/Else If statement called via class

Question

I am trying to figure out why this isn't working. What I am trying to do is return a value after the function is called. It is a login function which is supposed to check the database for the users status. That value being $userStatus. Depending on the status I'd like to return a value which would then trigger the error. However the script only fires off the first else if statement.

Here is the index page which calls the script

if(isset($_POST['btn-login'])) {
    $uname = strip_tags($_POST['txt_uname_email']);
    $umail = strip_tags($_POST['txt_uname_email']);
    $upass = strip_tags($_POST['txt_password']);

    if ($login->doLogin($uname,$umail,$upass)) {
        $login->userLoginTime($uname);
        $login->redirect('home.php');

    } else if ($userStatus == 0) {
        $error = "Your account is not active!";

    } else if ($userStatus == "") {
        $error = "You don't have an account, please sign up";

    }
}
?>

Here is the class page where the function is housed.

public function doLogin($uname,$umail,$upass)
{
    try 
    {
        $stmt = $this->conn->prepare("SELECT
            user_id, user_name, user_email, user_pass, Enabled
            FROM users WHERE user_name=:uname OR user_email=:umail ");
        $stmt->execute(array(':uname'=>$uname, ':umail'=>$umail));
        $userRow=$stmt->fetch(PDO::FETCH_ASSOC);

        $userStatus = $userRow['Enabled'];

        if ($userStatus == 5) {
            if ($stmt->rowCount() == 1) {
                if (password_verify($upass, $userRow['user_pass'])) {
                    $_SESSION['user_session'] = $userRow['user_id'];
                    return true;
                }
            } else {
                return false;
            }
        }
        if ($userStatus == 0) {
            return $userStatus;
        }
        if ($userStatus == "") {
            return $userStatus;
        }
    }

Yes I do have an instance of the class at the very top of the page, sorry for not including it. — CoderPoet
– CoderPoet, Commented Mar 7, 2016 at 23:46

Jason Hazel · Accepted Answer · 2016-03-08 00:22:12Z

5

$userStatus is never being set. You'll want to set it before your if:

$userStatus = $login->doLogin($uname,$umail,$upass);
if($userStatus === true) {       
   $login->userLoginTime($uname);
   $login->redirect('home.php');
} else if ($userStatus === 0) {
   $error = "Your account is not active!";
} else if ($userStatus === "") {
   $error = "You don't have an account, please sign up";
}

edited Mar 8, 2016 at 0:22

answered Mar 7, 2016 at 23:48

Jason Hazel

1411 silver badge5 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

CoderPoet Over a year ago

I will try this. Does this still apply even though the user status is being set in the class?

Jason Hazel Over a year ago

The class and your code calling it are in different scopes. Data doesn't pass freely between them. return $userStatus in your class is saying, "Hey, I'm done and here is this data you can use," but the code calling it never takes that data and stores it anywhere, so it gets lost.

Cave Johnson Over a year ago

I think it would be a good idea to use === instead of ==. That last condition may never be reached.

CoderPoet Over a year ago

Thank you very much. I'll try this and read up on it using the link you've provided. If it works I'll be sure to make it as the answer

Jason Hazel Over a year ago

@Andrew - Right on. They're both falsy values.

Blablaenzo · Accepted Answer · 2016-03-07 23:47:36Z

1

maybe "txt_uname_email" in

$uname = strip_tags($_POST['txt_uname_email']);

is incorrect? Something with name?

answered Mar 7, 2016 at 23:47

Blablaenzo

1,0571 gold badge11 silver badges15 bronze badges

3 Comments

CoderPoet Over a year ago

I am able to login using the function if my user name and password are correct. However if my password is wrong I want it to say incorrect password. And when the password is right it should check the usersstatus and if not active it should echo user not active

CoderPoet Over a year ago

However the only error i receive is user not active although it is my password that is wrong

Blablaenzo Over a year ago

You put the posted email in the $uname variable.

Collectives™ on Stack Overflow

PHP Returning value from If/Else If statement called via class

2 Answers 2

5 Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related