Getting filename from path using QString basic functions

Question

There's some path as QString:

QString path = "C:/bla/blah/x/y/file.xls";

I thought that maybe getting last offset of / would be a good start. I could then use right method (no pun intended) to get everything after that character:

path = path.right(path.lastIndexOf("/"));

or in a more compatible way:

path = path.right(std::max(path.lastIndexOf("\\"), path.lastIndexOf("/")));

Those both have the same bad result:

ah/x/y/file.xls

What's wrong here? Obviously the path is getting cut too soon, but it's even weirder it's not cut at any of / at all.

QFileInfo( "C:/bla/blah/x/y/file.xls" ).fileName();.

Dmitry Sazonov
– Dmitry Sazonov

2016-03-14 13:03:01 +00:00
Commented Mar 14, 2016 at 13:03 — Dmitry Sazonov
– Dmitry Sazonov, Commented Mar 14, 2016 at 13:03

Ilya · Accepted Answer · 2016-03-14 13:00:24Z

21

The QString method you want is mid, not right (right counts from the end of the string):

path = path.mid(path.lastIndexOf("/"));

mid has a second parameter, but when it's omitted you get the rightmost part of the string.

And for a cleaner / more universal code:

QFileInfo fi("C:/bla/blah/x/y/file.xls");
QString fileName = fi.fileName();

NB QFileInfo doesn't query the file system when it doesn't have to, and here it doesn't have to because all the infos are in the string.

answered Mar 14, 2016 at 13:00

Ilya

5,6272 gold badges21 silver badges35 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

weeska · Accepted Answer · 2016-03-14 11:58:29Z

1

From QString::right():

"Returns a substring that contains the n rightmost characters of the string."

You're using the index as a count. You'd have to use .size() - .indexOf().

answered Mar 14, 2016 at 11:58

weeska

4614 silver badges9 bronze badges

Collectives™ on Stack Overflow

Getting filename from path using QString basic functions

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related