Function that checks if something is a variable

Question

I have recently came across another problem with using functions for a tic tac toe game. What I want this function to do is check if any of the players have won through the function 'win'. The function works in my original code but that required me to re write it 4 times. I wanted to simplify it by making it a function but I cannot seem to get it to work. I have tried adding global variables in the beginning of the function, but that doesn't seem to be the case.

num1 = '1'
num2 = '2'
num3 = '3'
num4 = '4'
num5 = '5'
num6 = '6'
num7 = '7'
num8 = '8'
num9 = '9'
player1_mark = "X"
player2_mark = "O"
endgame = False

def drawBoard():
    ''' Prints the board'''
    print

def win(x):
    if (num1 == x and num2 == x and num3 == x):
        drawBoard()
        print "The computer wins!"
        endgame = True
    elif (num1 == x and num5 == x and num9 == x):
        drawBoard()
        print "The computer wins!"
        endgame = True
    elif (num1 == x and num4 == x and num7 == x):
        drawBoard()
        print "The computer wins!"
        endgame = True
    elif (num4 == x and num5 == x and num6 == x):
        drawBoard()
        print "The computer wins!"
        endgame = True
    elif (num7 == x and num8 == x and num9 == x):
        drawBoard()
        print "The computer wins!"
        endgame = True
    elif (num7 == x and num5 == x and num3 == x):
        drawBoard()
        print "The computer wins!"
        endgame = True
    elif (num1 == x and num2 == x and num3 == x):
        drawBoard()
        print "The computer wins!"
        endgame = True
    elif (num8 == x and num5 == x and num2 == x):
        drawBoard()
        print "The computer wins!"
        endgame = True
    elif (num9 == x and num6 == x and num3 == x):
        drawBoard()
        print "The computer wins!" 
        endgame = True
    elif (num1 != '1' and num2 != '2' and num3 != '3' and num4 != '4' and num5 != '5' and num6 != '6' and num7 != '7' and num8 != '8' and num9 != '9'):
        drawBoard()
        print "Draw"
        endgame = True

'''Lets say that the player gets the row 1 2 and 3'''
num1 = 'X'
num2 = 'X'
num3 = 'X'
while True:
    win(player1_mark)
    while endgame == True:
        print 'You win!'
        break

Cheers

Why are you using nine separate variables for your game board instead of, e.g., a list or a list of lists? — kindall
– kindall, Commented Mar 15, 2016 at 22:33
Sorry, but your code is a real mess. You should rewrite it. Eg. are you intentionally checking twice whether (num1 == x and num2 == x and num3 == x)? I suspect it's your design, all the repetitions, that eventually makes it hard to follow the logic. — jDo
– jDo, Commented Mar 15, 2016 at 22:47

DavedeKoning · Accepted Answer · 2016-03-15 22:39:19Z

1

I do not understand your code, but you can make it work by returning endgame from the function. Add this at the end of the function:

def win(x):
    ...
    #all the if/elif statements#
    ...
    return endgame

Also I do not know why you call all the while loops. I would suggest the following:

endgame = win(player1_mark)
if endgame == True:
     print "You win!"

Cheers

answered Mar 15, 2016 at 22:39

DavedeKoning

1901 silver badge7 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Till · Accepted Answer · 2016-03-15 22:43:09Z

1

A quick modification would look like this (return the equal value, remove the second while, and remove duplicate code with a longer boolean formula) :

num1 = '1'
num2 = '2'
num3 = '3'
num4 = '4'
num5 = '5'
num6 = '6'
num7 = '7'
num8 = '8'
num9 = '9'
player1_mark = "X"
player2_mark = "O"

def drawBoard():
    ''' Prints the board'''
    print

def win(x):
    if (num1 == x and num2 == x and num3 == x) or (
        num1 == x and num5 == x and num9 == x) or (
        num1 == x and num4 == x and num7 == x) or (
        num4 == x and num5 == x and num6 == x) or (
        num7 == x and num8 == x and num9 == x) or (
        num7 == x and num5 == x and num3 == x) or (
        num1 == x and num2 == x and num3 == x) or (
        num8 == x and num5 == x and num2 == x) or (
        num9 == x and num6 == x and num3 == x) :
        drawBoard()
        print "The computer wins!"
        return True
    elif (num1 != '1' and num2 != '2' and num3 != '3' and num4 != '4' and num5 != '5' and num6 != '6' and num7 != '7' and num8 != '8' and num9 != '9'):
        drawBoard()
        print "Draw"
        return True
    else:
        return False
'''Lets say that the player gets the row 1 2 and 3'''
num1 = 'X'
num2 = 'X'
num3 = 'X'
while True:
    endgame = win(player1_mark)
    if(endgame):
        print 'You win!'
        break

answered Mar 15, 2016 at 22:43

Till

4,6013 gold badges19 silver badges20 bronze badges

1 Comment

the happy mamba Over a year ago

Exactly - good answer instead of chastising the OP about their code.

Collectives™ on Stack Overflow

Function that checks if something is a variable

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related