Removing Thread from an arraylist, stack,queue after finishing task

Question

Everyone know factorial right. I m practicing Thread and class relationship. My question is getting results from thread class. If you suggest callbacks, Can you implement callback class for this example.

public class factorial extends Thread {
    int sz = 0;
    List < String > ar = new ArrayList < String > ();
    public factorial(int n) {
        this.sz = n;
    }
    public void run() {
        int p = 1;
        for (int i = 1; i <= sz; i++) {
            p *= i;
            ar.add(p + "");
        }
    }
}
public class Test {
    public static List < String > ans = new ArrayList < String > ();
    public static void main(String[] args) {
        factorial f1 = new factorial(10);
        factorial f2 = new factorial(8);
    }
}

f1.start() should start the thread storing the incremental factorial values in the list ar. Not sure if i am getting your question. — rahulbmv
– rahulbmv, Commented Mar 16, 2016 at 18:36

Balázs Édes · Accepted Answer · 2016-03-16 18:46:46Z

1

In your main:

// Start both threads
f1.start();
f2.start();

// Wait until they are finished
f1.join();
f2.join();

// Here are your lists
List<String> f1Strings = f1.ar;
List<String> f2Strings = f2.ar;

However, I can't help myself from codereviewing a bit:

Class names start with a capital letter (Factorial), and should be more descriptive, eg.: FactorialCalculatorThread
Don't access fields directly (like I did in the example above), use getters (getSomething) and use descriptive names!
Also separate concerns! I wouldn't calculate factorials, and also convert to string in one method.

edited Mar 16, 2016 at 18:46

answered Mar 16, 2016 at 18:39

Balázs Édes

13.9k7 gold badges60 silver badges105 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Removing Thread from an arraylist, stack,queue after finishing task

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related