jQuery click() outputs information for wrong button multiple times

Question

Firstly, here is my code:

$.each(obj, function(k,v) {   // k ==== key, v === value
{
    output = "";

    output = output.concat(v.info1);
    output = output.concat("<br />");

    output = output.concat(v.info2);
    output = output.concat("<br />");

    output = output.concat("<br />");

    var a = document.createElement('a');
    a.innerHTML = output;
    $("#myDiv").append(a);
    $("#myDiv").on('click', a, function(e) {
        //alert(output);
        var w = window.open("");
        w.document.write(output);
    });
});

Now, this is what I'm trying. In each iteration, I want to attach an "output" string (to "myDiv"), which on clicking, opens a new tab, and displays pertinent information (let that be the "output" string itself, for now).
Using the above code, when I click on any link, it opens as many new tabs as the number of records present, each displaying information only about the last record.
Could anybody tell what could be going wrong? Thanks!

take your click event out of the loop, why do you need it in there? — Train
– Train, Commented Mar 27, 2016 at 1:19

Kyle · Accepted Answer · 2016-03-27 01:26:08Z

1

Move $("#myDiv").on outside of the $.each like this:

$.each(obj, function(k,v) {   // k ==== key, v === value
  output = "";

  output = output.concat(v.info1);
  output = output.concat("<br />");

  output = output.concat(v.info2);
  output = output.concat("<br />");

  output = output.concat("<br />");

  var a = document.createElement('a');
  a.innerHTML = output;
  $("#myDiv").append(a);
});

$("#myDiv").on('click', 'a', function(e) {
  var w = window.open("");
  w.document.write(this.innerHTML);
});

answered Mar 27, 2016 at 1:26

Kyle

4032 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

jQuery click() outputs information for wrong button multiple times

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related