No variable member function declared in class?

Question

can sombody explain to me why my code will not work, and how to fix it thanks :)

I keep recieving this error :

no 'int burrito::setName()' member function declared in class 'burrito'

My goal is to call a function from a different class file

My main.cpp :

#include <iostream>
#include "burrito.h"
using namespace std;

int main()
{

burrito a;
a.setName("Ammar T.");


return 0;
}

My class header (burrito.h)

#ifndef BURRITO_H
#define BURRITO_H


class burrito
{
public:
    burrito();
};

#endif // BURRITO_H

My class file (burrito.cpp):

#include "burrito.h"
#include <iostream>

using namespace std;

burrito::setName()
{
  public:
    void setName(string x){
        name = x;


    };
burrito::getName(){

    string getName(){
        return name;
    };

}

burrito::variables(string name){
    string name;
               };

private:
    string name;
};

You need to define all the functions in the header and in the cpp. Google a sample header program — Khalil Khalaf
– Khalil Khalaf, Commented Apr 6, 2016 at 23:13
Your burrito has no variables (data members) declared in the class. Your variables method has local variables that disappear after execution leaves the method. — Thomas Matthews
– Thomas Matthews, Commented Apr 6, 2016 at 23:19
Your source file has private section and }; not associated with anything. Maybe you wanted to move these lines to the end of your Burrito. — Thomas Matthews
– Thomas Matthews, Commented Apr 6, 2016 at 23:20

Khalil Khalaf · Accepted Answer · 2016-04-06 23:35:58Z

1

Your code is a mess. You need to write function prototypes in the header file and function definitions in the cpp file. You are missing some basic coding structures. See below and learn this pattern of coding:

This code should work and enjoy burritos !

main():

#include <iostream>
#include "Header.h"

int main()
{
    burrito a;
    a.setName("Ammar T.");

    std::cout << a.getName() << "\n";

    getchar();
    return 0;
}

CPP file:

#include "Header.h"
#include <string>

void burrito::setName(std::string x) { this->name = x; }
std::string burrito::getName() { return this->name; }

Header file:

#include <string>

class burrito
{
private:
    std::string name;

public:
    void setName(std::string);
    std::string getName();
    //variables(string name) {string name;} // What do you mean by this??
};

edited Apr 6, 2016 at 23:35

answered Apr 6, 2016 at 23:24

Khalil Khalaf

9,39712 gold badges68 silver badges109 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Ammar T. Over a year ago

Thanks for this! Sorry for this mess, I'm new to c++

Thomas Matthews Over a year ago

A common coding guideline is to provide parameter names in the declarations of methods.

Khalil Khalaf Over a year ago

@AmmarT glad it helped. Please mark it as an answer if you see it working :)

sjrowlinson Over a year ago

Do NOT put using namespace std; in the header file, this creates namespace pollution - see here: stackoverflow.com/questions/1452721/…

Khalil Khalaf Over a year ago

But this is for beginners? @archbishopofbanterbury

|

Thomas Matthews · Accepted Answer · 2016-04-06 23:31:16Z

0

Your poor little burrito is confused. Confused burritos can't help much.

You may want your burrito declaration as:

class Burrito
{
public:
    Burrito();
    void set_name(const std::string& new_name);
    std::string get_name() const;
private:
    std::string name;
};

The methods could be defined in the source file as:

void
Burrito::set_name(const std::string& new_name)
{
  name = new_name;
}

std::string
Burrito::get_name() const
{
  return name;
}

edited Apr 6, 2016 at 23:31

answered Apr 6, 2016 at 23:25

Thomas Matthews

58.1k18 gold badges106 silver badges165 bronze badges

9 Comments

Khalil Khalaf Over a year ago

this is too much for a beginner.

sjrowlinson Over a year ago

set_name needs a void return type in header file :)

Thomas Matthews Over a year ago

@FirstStep: How is this too much for a beginner? I took the OP's code and organized it correctly.

Ammar T. Over a year ago

@FirstStep I have no idea what either of those are, thats why I went with yours since it didn't add anything I didn't know.

Thomas Matthews Over a year ago

@FirstStep: Then he has a poor education. I recommend that references be taught before function creation.

|

nivbala · Accepted Answer · 2016-04-06 23:33:38Z

0

The header file only has a constructor for the class. The member functions

   setName(string) and getName()

are not declared in the header file and that is why you get the error. Also, you need to specify the return type for functions.

One way to do this would be

 //Header 
 //burrito.h   
class burrito{
   private:
   string burrito_name; 
   public:
       burrito();
       string getName(); 
       void setName(string);
             }

//burrito.cpp
#include "burrito.h"
#include <iostream>

using namespace std;

string burrito::getName()
{
return burrito_name; 
}

void burrito::setName(string bname)
{
 bname =burrito_name;
}

edited Apr 6, 2016 at 23:33

answered Apr 6, 2016 at 23:30

nivbala

31 silver badge6 bronze badges

2 Comments

Khalil Khalaf Over a year ago

the member function setName() needs a string as a parameter :)

nivbala Over a year ago

@FirstStep Were you pointing to the setName() on the first line? I just edited it

score 0 · Accepted Answer · 2016-08-09 11:10:31Z

0

This is a simple example for class in C++,
Save this in burrito.cpp file then compile and run it:

#include <iostream> 
#include <string> 
using namespace std;
class burrito {
public:
    void setName(string s);
    string getName();
private:
    string name;
};

void burrito::setName(string s) {
    name = s;
}
string burrito::getName() {
    return name;
}

int main() {
    burrito a;
    a.setName("Ammar T.");
    std::cout << a.getName() << "\n";
    return 0;
}

edited Aug 9, 2016 at 11:10

answered Apr 6, 2016 at 23:49

user6169399

Collectives™ on Stack Overflow

No variable member function declared in class?

can sombody explain to me why my code will not work, and how to fix it thanks :)

4 Answers 4

7 Comments

9 Comments

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

can sombody explain to me why my code will not work, and how to fix it thanks :)

4 Answers 4

7 Comments

9 Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related