How do we create c# method to accept different types of parameter

Question

I am new to asp.net and creating a MVC project using entities framework. Mostly it work as I expected but have an issue where I need to pass parameters to a method which could be of different types. I need this because I dont want to write same method in each class which send same results. Here is my setup

public class BaseQuery : IOSSQuery
{
    private Entities dbcontext;

    public BaseQuery() : this(new Entities())
    {
    }
    public BaseQuery(Entities context)
    {
        this.dbcontext = context;
    }
    public List<SimpleItem> GetAllItemsFromQuery<T>( T table,Int32 skip)
    {
        List<SimpleItem> SimpleItemList = new List<SimpleItem>();
        SimpleItemList = table.Where(p => p.IsActive == true).OrderBy(p => p.Name).Select(p => new SimpleItem { id = p.Id, Name = p.Name, IsActive = p.IsActive }).Skip(skip).Take(30).Distinct().ToList();
        return SimpleItemList;
    }
    public virtual List<SimpleItem> GetAllItems(Int32 skip)
    {
        List<SimpleItem> SimpleItemList = new List<SimpleItem>();
        return SimpleItemList;
    }
}

Then I have a query class,

public class ColorQuery : BaseQuery
{
    public override List<SimpleItem> GetAllItems(Int32 skip)
    {
        return GetAllItemsFromQuery( dbcontext.tbl_color, skip)
    }
}

Here is the interface

public interface IOSSQuery : IDisposable
{
    List<SimpleItem> GetAllItems(Int32 skip);
}

I would like to call the method from my controller as following

public JsonResult Color(String range)
{
   ColorQuery query = new ColorQuery();
   List<string> ranges = range.Split(',').ToList<string>();
   var SimplePage = getAllItems(query, Convert.ToInt32(ranges[0]));
   return Json(SimplePage, JsonRequestBehavior.AllowGet);
}

public PagedData<SimpleItem> getAllItems( IOSSQuery queryObject,  int range )
{
   var SimplePage = new PagedData<SimpleItem>();
   SimplePage.total = queryObject.TotalItems();
   SimplePage.data = queryObject.GetAllItems(range);
   return SimplePage;
}

This code throw error at this line in BaseQuery class

public List<SimpleItem> GetAllItemsFromQuery<T>( T table,Int32 skip)

Error   CS1061  'T' does not contain a definition for 'Where' and no extension method 'Where' accepting a first argument of type 'T' could be found (are you missing a using directive or an assembly reference?)

Not sure how do I pass different types in the method. I tried solution from Method to accept different types without luck. Can anybody shed lights on this. Thanks for your time.

Edits: This is how it setup in my entities

public DbSet<tbl_Category> tbl_Category { get; set; }
public DbSet<tbl_color> tbl_color { get; set; }

EDIT 2:

I have multiple tables with different columns. My idea is to use generic method from "BaseQuery" for all tables which returns same result still want to use "ColorQuery" or say "CategroyQuery" class for different query if I need.

Why do you implement "IOSSQuery" in your class "ColorQuery", "BaseQuery" already implements it ? — Aliz
– Aliz, Commented Apr 7, 2016 at 9:13

Jordi Ruiz · Accepted Answer · 2016-04-07 09:19:50Z

1

why don't you try with an IQueryable parameter instead of a generic Type Parameter?

public List<SimpleItem> GetAllItemsFromQuery(IQueryable table,Int32 skip)
    {
        List<SimpleItem> SimpleItemList = new List<SimpleItem>();
        SimpleItemList = table.Where(p => p.IsActive == true).OrderBy(p => p.Name).Select(p => new SimpleItem { id = p.Id, Name = p.Name, IsActive = p.IsActive }).Skip(skip).Take(30).Distinct().ToList();
        return SimpleItemList;
    }

answered Apr 7, 2016 at 9:19

Jordi Ruiz

4872 silver badges11 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Sameer Kumar Jain Over a year ago

Doesn't work, same error 'IQueryable' does not contain a definition for 'Where' and no extension method 'Where' accepting a first argument of type 'IQueryable' could be found (are you missing a using directive or an assembly reference?)

FacticiusVir · Accepted Answer · 2016-04-07 09:25:04Z

1

When you make the GetAllItemsFromQuery method generic (using T as a parameter type) the compiler no longer knows what type of object it is receiving in parameter table - so when you invoke members like IsActive or extension methods like Where, the compiler cannot bind them to concrete implementations; in fact, it can't tell if the object you're passing in even /has/ those members. You can give the compiler more information about the types it can expect using where clauses on the method declaration:

public List<SimpleItem> GetAllItemsFromQuery<T>( T table,Int32 skip)
    where T: IEnumerable<IEntity>
{
    List<SimpleItem> SimpleItemList = new List<SimpleItem>();
    SimpleItemList = table.Where(p => p.IsActive == true).OrderBy(p => p.Name).Select(p => new SimpleItem { id = p.Id, Name = p.Name, IsActive = p.IsActive }).Skip(skip).Take(30).Distinct().ToList();
    return SimpleItemList;
}

Assuming that all your entity types implement IEntity, which would be an interface including Id, Name, IsActive et cetera.

It would be easier to give you a specific answer if we could see the code for the Entities type, but in terms of what you're trying to do the where clause is the way to go.

answered Apr 7, 2016 at 9:25

FacticiusVir

2,07715 silver badges28 bronze badges

1 Comment

Sameer Kumar Jain Over a year ago

Its setup as public DbSet<tbl_color> tbl_color { get; set; } in entities class

Ian · Accepted Answer · 2016-04-07 15:33:17Z

1

It seems like you T table is should be limited to IEnumerable<T> because you use it like an IEnumerable<T>:

SimpleItemList = table.Where(p => p.IsActive == true).OrderBy(p => p.Name).Select(p => new SimpleItem { id = p.Id, Name = p.Name, IsActive = p.IsActive }).Skip(skip).Take(30).Distinct().ToList();

Try to declare it using where (using System.Linq):

public List<SimpleItem> GetAllItemsFromQuery<T, U>(T table,Int32 skip) where T : System.Collections.IEnumerable<U>

Or simply:

public List<SimpleItem> GetAllItemsFromQuery<T>(IEnumerable<T> table,Int32 skip)

edited Apr 7, 2016 at 15:33

answered Apr 7, 2016 at 9:14

Ian

30.9k20 gold badges77 silver badges112 bronze badges

1 Comment

FacticiusVir Over a year ago

T can't be an IEnumerable<T>, else the type will be an enumeration of itself. Do you mean T: IEnumerable<U> for GetAllItemsFromQuery<T, U>, or simply GetAllItemsFromQuery<T>(IEnumerable<T> table,Int32 skip)?

Vova · Accepted Answer · 2016-04-07 09:11:36Z

0

You can use function name overload. It's OK.

answered Apr 7, 2016 at 9:11

Vova

491 silver badge7 bronze badges

Comments

Jordi Ruiz · Accepted Answer · 2016-04-07 10:11:28Z

0

Sammer,

the problem in your code is that you are using a generic Type Parameter, as @FacticiusVir said, the compiler can't know which kind of Type is, but at the same time you want this type to have an Id property, a Name property and IsActive property.

So you can do two things:

Make the method GetAllItemsFromQuery more specific, something like that:


        public List GetAllItemsFromQuery(IEnumerable table, Int32 skip)
        {
            List SimpleItemList = new List();
            SimpleItemList = table.Where(p => p.IsActive).OrderBy(p => p.Name).Select(p => new SimpleItem { id = p.Id, Name = p.Name, IsActive = p.IsActive }).Skip(skip).Take(30).Distinct().ToList();
            return SimpleItemList;
        }

Make it generic with a restriction and create a base class for your entities with the three properties mentioned before:

public class tbl_color: BaseEntity
{

}

public class BaseEntity
{
    public bool IsActive { get; set; }
    public string Name { get; set; }
    public int Id { get; set; }
}

public List<SimpleItem> GetAllItemsFromQuery<T>(IEnumerable<T> table, Int32 skip) where T : BaseEntity
{
    List<SimpleItem> SimpleItemList = new List<SimpleItem>();
    SimpleItemList = table.Where(p => p.IsActive).OrderBy(p => p.Name).Select(p => new SimpleItem { id = p.Id, Name = p.Name, IsActive = p.IsActive }).Skip(skip).Take(30).Distinct().ToList();
    return SimpleItemList;
}

edited Apr 7, 2016 at 10:11

answered Apr 7, 2016 at 10:05

Jordi Ruiz

4872 silver badges11 bronze badges

2 Comments

Jordi Ruiz Over a year ago

Sammer, the Where is an extension method for the IEnumerable interface, make sure that you have added the System.Linq namespace.

Sameer Kumar Jain Over a year ago

Oh right, So I have to edit all my class definitions for Entities to add an interface. That is pain.

Collectives™ on Stack Overflow

How do we create c# method to accept different types of parameter

5 Answers 5

1 Comment

1 Comment

1 Comment

Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

1 Comment

1 Comment

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related