SQL query in PHP only works outside function

Question

I have the following PHP snippet:

function getFacilities($testName, $dbAdapter) {
  $sql1 = "SELECT * FROM facilities_db WHERE facility_name = '$testName'";
  $result1 = $dbAdapter->query($sql1);

  $facility_details = array();
  while ($row = mysqli_fetch_assoc($result1))
  {
    $facility_details[] = $row;
  }
  return $facility_details;
}

$testName = "Abraham Moss Leisure";
$facility_data = getFacilities($testName, $mysqli);

The value of $testName is arbitrary just for testing purposes. This is the function from one of the answers, but my the only difference in my initial definition was not having $dbAdapter as a parameter.

please post your whole function & how did you call the function with parameter. — Dipanwita Kundu
– Dipanwita Kundu, Commented Apr 11, 2016 at 10:56
Also don't forget to check scope of all your variables with and without function!! — Mangesh Sathe
– Mangesh Sathe, Commented Apr 11, 2016 at 11:04

Unex · Accepted Answer · 2016-04-11 12:14:04Z

6

You need to set $testName as a parameter, but also the adapter you are going to use to get the connection to your SGBD (here it's mysqli).

function getFacilities($testName, $dbAdapter) {
    $sql1 = "SELECT * FROM facilities_db WHERE facility_name = '$testName'";
    $result1 = $dbAdapter->query($sql1);

    $facility_details = array();
    while ($row = mysqli_fetch_assoc($result1))
    {
      $facility_details[] = $row;
    }
    return $facility_details;
}

We need to pass $testName and $mysqli as your dbAdapter to the function. Thus, this is how we would call the function :

$facility_data = getFacilities($testName, $dbAdapter);

hope this'll help,

edited Apr 11, 2016 at 12:14

answered Apr 11, 2016 at 11:04

Unex

1,76713 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

arch1ve Over a year ago

The array returned is still empty :(. If I call the function using a string instead of $testName for example, the same thing happens.

arch1ve Over a year ago

Yes. I just checked it without the function and it works like a charm.

arch1ve Over a year ago

Worked after defining $dbAdapter as a global variable with $mysqli value and only parsing the $testName (for whatever reason that is...). Thanks!

vp_arth Over a year ago

If global answer works for you - you must try to provide $dbAdapter instead of $mysqli to getFacilities call.

arch1ve Over a year ago

All right, I added the $dbAdapter parameter back and parsed it when calling the function after defining it as $mysqli.

harry · Accepted Answer · 2016-04-11 12:09:00Z

0

test query result:

print_r(mysqli_fetch_assoc($result));

test $mysqli in function:

function get($testName, $adapter) { if (!isset($adapter)) echo 'no'; }

use static database connection:

class GlobalClass { public static $db = null; }

class Connection {
public $connection = null;
public function connect() {
    if ($connection == null)
        // operation
    $this->connection = 'obj';
}}


$db = new Connection();
$db->connect();
GlobalClass::$db = new Connection();
GlobalClass::$db->connect();
GlobalClass::$db->connection->query($sql);

function yourFunction($testName) {
    $sql1 = "SELECT * FROM facilities_db WHERE facility_name = '$testName'";

    $result1 = GlobalClass::$db->connection->query($sql1);

    $facility_details = array();
    while ($row = mysqli_fetch_assoc($result1)) {
      $facility_details[] = $row;
    }
    return $facility_details;
}

edited Apr 11, 2016 at 12:09

answered Apr 11, 2016 at 11:47

harry

4832 silver badges12 bronze badges

1 Comment

arch1ve Over a year ago

Thanks for the effort, but the database connection is already written and it works fine for everything else I have! Solved the problem.

Arun Kumaresh · Accepted Answer · 2016-04-11 11:47:03Z

-1

    function getFacilities($testName) {
          global $dbAdapter;
        $sql1 = "SELECT * FROM facilities_db WHERE facility_name = '$testName'";
        $result1 = $dbAdapter->query($sql1);

        $facility_details = array();
        while ($row = mysqli_fetch_assoc($result1))
        {
          $facility_details[] = $row;
        }
        return $facility_details;
    }

$testName = "Abraham Moss Leisure";
$facility_data = getFacilities($testName);

declare the connection variable as global and pass the value for the $testname

answered Apr 11, 2016 at 11:47

Arun Kumaresh

6,2966 gold badges37 silver badges50 bronze badges

7 Comments

arch1ve Over a year ago

Even though I don't know why, this worked. Thank you!

vp_arth Over a year ago

omg, please, no... Why php maintainers do not removed that global yet?

Unex Over a year ago

You shouldn't use global variables. It leads to very high technical debt.

Arun Kumaresh Over a year ago

why cant use global variable can you plz explain then how can use the connection variable inside the function

Unex Over a year ago

You should check here : stackoverflow.com/questions/1557787/….

|

Collectives™ on Stack Overflow

SQL query in PHP only works outside function

3 Answers 3

5 Comments

1 Comment

7 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

5 Comments

1 Comment

7 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related