Why is my php "if statement" not affecting my mysql query?

Question

First of all, I know mysql is deprecated. Will change to mysqli as soon as I figure out the issue at hand. My query continues to update all my rows even if the data is not set in the 'stripetoken' column. Why is this happening?

Code snippet:

$token_query = 'SELECT * FROM jobsubmission';
$token_res = mysql_query($token_query);
$token_row = mysql_fetch_array($token_res);


if(isset($token_row['stripetoken'])) {
    $updqry = 'UPDATE jobsubmission SET assigned=1 WHERE ID="'.$book_ids[$jcount].'"';
    $update = mysql_query($updqry);
    $bookdate = date("d-m-Y");

Please note that mysql_* is now deprecated as of PHP7 because of security issues. It is suggested that you switch to mysqli_* or PDO extensions. — Pedro Lobito
– Pedro Lobito, Commented Apr 21, 2016 at 0:33
@PedroLobito Thanks Pedro. If you read my preliminary paragraph you would see that I had acknowledged that — Jb1128
– Jb1128, Commented Apr 21, 2016 at 1:06
Why don't you actually fetch it ? while ($token_row = mysql_fetch_array($token_res)) { if ($token_row['stripetoken']... — Christian Bonato
– Christian Bonato, Commented Apr 21, 2016 at 1:22

John Conde · Accepted Answer · 2016-04-21 00:25:23Z

3

Because $token_row['stripetoken'] is always set because it is a column in your database and it will be available in $token_row as a result. Now whether it has a value or not is a different story. You should be using empty() instead (assuming you don't want it to be true for falsy values).

if(!empty($token_row['stripetoken'])) {

answered Apr 21, 2016 at 0:25

John Conde

220k100 gold badges464 silver badges504 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Funk Forty Niner Over a year ago

Nice to see you back John ;-)

John Conde Over a year ago

@Fred-ii- I'm trying to answer a question or two if I can help it. :)

Funk Forty Niner Over a year ago

You seem to be doing well :-)

John Conde Over a year ago

Life is good. :) I should jump in the chat room and say hi sometime soon.

Funk Forty Niner Over a year ago

That's great John, I'm glad to hear it. Life's good here too :-) Looking forward to it, cheers

|

Jb1128 · Accepted Answer · 2016-04-21 03:27:55Z

0

So while @JohnConde was absolutely correct in saying I needed to use the empty function over the isset, my solution layed elsewhere. Here is how I managed to get the query to work to my specifications:

instead of searching for empty, I made the 'stripetoken' column NULL by default.

This allowed me to use the following code:

$token_query = 'SELECT * FROM jobsubmission WHERE ID="'.$book_ids
[$jcount].'" and stripetoken is not null';
$token_res = mysql_query($token_query);
$token_row = mysql_fetch_object($token_res);

if(!$token_row->stripetoken == NULL) {

answered Apr 21, 2016 at 3:27

Jb1128

972 silver badges10 bronze badges

1 Comment

John Conde Over a year ago

FYI, empty() does exactly the same thing

Collectives™ on Stack Overflow

Why is my php "if statement" not affecting my mysql query?

2 Answers 2

6 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related