Return Response before calling methods in MVC Controller

Question

I do some Caching-Checks (etag) in my base controller called "CachingController"

public CachingController:Controller {
   public CachingController() {
      if (IsKnownEtag(Request.Headers["If-None-Match"])) {
         Response.StatusCode=304;
      }
   }
}

public MyController:CachingController {
  public ActionResult IsMagic(string dragonName) {   
     var isMagic=dragonName=="Puff";
     // ...
     SaveEtag();
     return new ActionResult(isMagic);
  }
}

So in the Constructor of my Base Controller I check if the Etag is valid. If it is, I want to return the status code. After I set the Status code I do not want that the Controller Action is still called. How can I do this without modifying each Action?

try Response.End(); after Response.StatusCode=304;

Karthik M R
– Karthik M R

2016-04-21 13:37:01 +00:00
Commented Apr 21, 2016 at 13:37 — Karthik M R
– Karthik M R, Commented Apr 21, 2016 at 13:37

peco · Accepted Answer · 2016-04-21 14:19:30Z

2

Move the etag logic to an ActionFilterAttribute instead:

public class EtagFilter : ActionFilterAttribute
{
    public override void OnActionExecuting(ActionExecutingContext filterContext)
    {
        if(IsKnownEtag(filterContext.HttpContext.Request.Headers["If-None-Match"]))
        {
            filterContext.Result = new HttpStatusCodeResult(HttpStatusCode.NotModified);
        }
    }

    //...
}

And then use it in your controller:

public class MyController : CachingController
{
    [EtagFilter]
    public ActionResult IsMagic(string dragonName)
    {
        var isMagic = dragonName == "Puff";
        // ...
        SaveEtag();
        return new ActionResult(isMagic);
    }
}

Also, move the SaveEtag() method to the filter so you keep that logic away from your controller.

answered Apr 21, 2016 at 14:19

peco

4,0001 gold badge23 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ole Albers Over a year ago

Sadly I cannot move the SaveETag() into the filter cause I make some validation-operations (Action 1 causes also Action 4 and 6 to revalidate etc.). Nonetheless. Your answer worked fine, thanks

Collectives™ on Stack Overflow

Return Response before calling methods in MVC Controller

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related