Disposing and resource management in C#

Question

I use BackGroundWorker and ProgressBar.

private void backgroundWorker1_DoWork(object sender, DoWorkEventArgs e)
{
    BackgroundWorker worker = sender as BackgroundWorker;

    e.Result = MyMethod((int)e.Argument, worker, e);

}

private void backgroundWorker1_ProgressChanged(object sender, ProgressChangedEventArgs e)
{
    progressBar1.Value = e.ProgressPercentage;
}

private void backgroundWorker1_RunWorkerCompleted(object sender, RunWorkerCompletedEventArgs e)
{
    tStripStatus.Text = "operation Ended.";
    tStripStatus.ForeColor = Color.Green;
}

In MyMethod I use Dispose() method for necessary resources.

While my app is start up, it uses ~10 000 K memory.
While my app is running, it uses between ~40 000 k - ~ 70 000k memory.
When operation is completed, it uses ~30 000 k memory.

How can I catch what is using 30 000 k - 10 000 k=~20 000 k memory?

You should post the MyMethod if you want an analysis of why it is possibly hogging up resources. But it might be just that the GC has not collected the memory yet. — Albin Sunnanbo
– Albin Sunnanbo, Commented Sep 16, 2010 at 8:00
@Albin, MyMethod is very hard for understand. I just want to know, which technologies other peoples and professionals use for resource problems. — loviji
– loviji, Commented Sep 16, 2010 at 8:47
How did you determine how much memory your application is actually using? If you just look at the “Memory (Private Working Set)” column in Task Manager, that doesn’t tell you anything. — Timwi
– Timwi, Commented Sep 16, 2010 at 8:53
@Timwi:I use "Memory (Private Working Set)" column, and run application. By values in this column I get memory quantity, that uses my application in different stages. But as I understand now, it's wrong way. — loviji
– loviji, Commented Sep 16, 2010 at 8:59

Keith · Accepted Answer · 2010-09-16 08:03:04Z

2

Calling Dispose() in .Net doesn't immediately collect the memory - it leaves it until it's not busy doing something else.

Basically it hasn't collected that 20MB because that wasted memory isn't slowing it down yet. Your machine probably has GB free, why stop and tidy up when there's still plenty of space?

Call GC.Collect() to force it, but note that this is usually slower than leaving .Net to do its thing - .Net is quite good at only collecting when it has to, as long as you've disposed of the resource.

answered Sep 16, 2010 at 8:03

Keith

157k82 gold badges314 silver badges453 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Jaco Pretorius Over a year ago

You will quite often notice the memory usage of your application doesn't decrease after you release resources - .NET will manage your memory and decide when to release memory or allocate more

John Saunders Over a year ago

Dispose has nothing to do with memory consumption.

Henk Holterman · Accepted Answer · 2010-09-16 08:59:58Z

1

How can I catch what is using 30 000 k - 10 000 k=~20 000 k memory?

By using a memory Profiler. But consider:

looking at a simple metric (Taskmanager) for 'memory consumption' is close to meaningless
you probably don't have a problem
it is unrelated to the Bgw

And for good measure:

Your Completed handler is not checking for errors. Could lead to nasty bugs.

answered Sep 16, 2010 at 8:59

Henk Holterman

276k33 gold badges353 silver badges540 bronze badges

Comments

HCL · Accepted Answer · 2010-09-16 08:10:18Z

1

You can try VMMap from Sysinternals. it's a free MS-tool that lets you analyse the memory-usage of a process.

If you are not very familiar with profiling an app, try this great video:

http://www.microsoftpdc.com/2009/CL11

It has a part about memory-analysis. As already written, don't count too much on values given by taskmanager and ProcessInfo. Because GC does not work immediately, there is a good chance that deallocation is not done yet because of efficiency.

edited Sep 16, 2010 at 8:10

answered Sep 16, 2010 at 7:58

HCL

36.9k29 gold badges167 silver badges221 bronze badges

Comments

Itay Karo · Accepted Answer · 2010-09-16 07:59:40Z

0

The CLR is responsible for the memory management so if you are not using external resources from your code the memory will be freed when the Garbage Collector will run.

answered Sep 16, 2010 at 7:59

Itay Karo

18.4k4 gold badges43 silver badges59 bronze badges

Comments

Bobby · Accepted Answer · 2010-09-16 07:59:52Z

0

If you wanna know what takes up this space, you'll have to use a Memory Profiler, like ProfileSharp.

answered Sep 16, 2010 at 7:59

Bobby

11.6k5 gold badges48 silver badges70 bronze badges

Comments

Madeleine · Accepted Answer · 2010-09-16 08:12:29Z

0

You could use ANTS memory profiler to have a look what is sitting in memory. Its a great tool for hunting for memory leaks etc - download a trial here: http://www.red-gate.com/products/ants_memory_profiler/index.htm

Is it possible that in MyMethod() you have perhaps hooked up an event from an external class which is not being unhooked up when you are complete with the method?

But as Keith mentioned, objects remain in memory until the Garbage collector runs. As long as they are properly disposed of they will be released when necessary. Even calling GC.Collect() does not guarantee that the Garbage collector will run immediately.

answered Sep 16, 2010 at 8:12

Madeleine

2,1822 gold badges24 silver badges37 bronze badges

Collectives™ on Stack Overflow

Disposing and resource management in C#

6 Answers 6

2 Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

2 Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related