angularjs cannot read property then of undefined [duplicate]

Question

I'm trying to return a mongodb collection from my server to the client, but am getting Cannot read property then of undefined on the server-side controller. I get that there is something wrong with the promise but can't seem to solve it. What code changes are needed to fix this? Let me know if more code snippets are needed.

The error occurs on ".then(....)" in the following function.

course.controller.js

function getAll(req,res){
    CourseService.getAll()
        .then(function(result){
            if(result){
                res.send(result);
            }else{
                res.sendStatus(404);
            }
        })
        .catch(function(err){
            res.status(400).send(err);
        });
}

CourseService calls this function:

course.service.js

function getAll(){
    console.log('services/course.service  getALL');
    var deferred = Q.defer();

    db.collection('courses').find().toArray(function(err, result) {
        if (err) deferred.reject(err);
        console.log(result);
        deferred.resolve();
        return deferred.promise;
    });   
}

Omri Aharon · Accepted Answer · 2016-05-18 08:01:48Z

3

You need to move the return statement outside:

function getAll(){
    console.log('services/course.service  getALL');
    var deferred = Q.defer();

    db.collection('courses').find().toArray(function(err, result) {
        if (err) deferred.reject(err);
        console.log(result);
        deferred.resolve();
    });   

    return deferred.promise;
}

answered May 18, 2016 at 8:01

Omri Aharon

17.1k5 gold badges43 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Pankaj Parkar · Accepted Answer · 2016-05-18 08:06:45Z

2

As you are trying to apply .then function over a promise, but promise object haven't being returned from the getAll function. Do return deferred.promise object from the getAll function will return the the promise.

Code

function getAll(){
    console.log('services/course.service  getALL');
    var deferred = Q.defer(); //assuming `Q` is `$q` dependency instance

    db.collection('courses').find().toArray(function(err, result) {
        if (err) deferred.reject(err);
        console.log(result);
        deferred.resolve();
    });   
    return deferred.promise; //return promise from here
}

You have that already returned promise, but that is not there in correct place, take it out of .collection function.

edited May 18, 2016 at 8:06

answered May 18, 2016 at 8:01

Pankaj Parkar

136k23 gold badges241 silver badges307 bronze badges

Collectives™ on Stack Overflow

angularjs cannot read property then of undefined [duplicate]

2 Answers 2

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Linked

Related