node.js callback strange behavior

Question

I face strange callback issue. I expect result return something but it didn't. Someone spot my mistake?

Models

module.exports.updateStatus = function(updateObj, callback){
    var order_id = updateObj.order_id,
    order_status = updateObj.order_status;
    Order.findOneAndUpdate({"_id": order_id}, {$set: {order_status: order_status}},{new: true});

My Routes

var Orders = require('../models/orders');
router.post('/update_status',function(req,res,next){
  var updateObj = {
    'order_status':req.body.order_status,
    'order_id':req.body.order_id
  }
  Orders.updateStatus(updateObj,function(err,result){
    console.log(result) // nothing been return here
  })

})

I check my db, the update is actually working fine. I do

module.exports.updateStatus = function(updateObj, callback){
        var order_id = updateObj.order_id,
        order_status = updateObj.order_status;
        Order.findOneAndUpdate({"_id": order_id}, {$set: {order_status: order_status}},{new: true},function(err,result){
console.log(result)// it work here
});

Bertrand Marron · Accepted Answer · 2016-05-21 11:02:44Z

2

You’re never calling callback in updateStatus, I don’t see why it would ever be called.

If you want it to be called, call it.

The findOneAndUpdate statement of updateStatus should be:

Order.findOneAndUpdate(
    {"_id": order_id},
    {$set: {order_status: order_status}},
    {new: true},
    callback
);

answered May 21, 2016 at 11:02

Bertrand Marron

22.3k8 gold badges63 silver badges95 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jamie Jordan Over a year ago

aw what a careless mistake!

KibGzr · Accepted Answer · 2016-05-21 11:03:50Z

0

you must call callback in updateStatus function

exports.updateStatus = function (updateObj, callback) {
    Order.findOneAndUpdate(
        {"_id": updateObj.order_id},
        {$set: {order_status: updateObj.order_status}},
        {new: true},
        callback
    );
}

answered May 21, 2016 at 11:03

KibGzr

2,09316 silver badges16 bronze badges

Collectives™ on Stack Overflow

node.js callback strange behavior

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related