JavaScript If statement issue

Question

I'm new here, and this is the first question to be asked by me.

I'm a beginner in programming and coding, I'm trying to make a basic system to view students' marks by entering their school numbers. Here's my code:-

<html>
<body>
<head>
<title>Test</title>
</head>

<input type="text" id="txtjob">
<button onclick="getnatega()">OK</button>


<script>
function getnatega() {
if (txtjob == 2386) {
window.location.href = "www.ex.com";
}
}
</script>
</body>
</html>

But whenever i click the "OK" button nothing happens. I'd be thankful to whoever helps me.

Nina Scholz · Accepted Answer · 2016-05-22 07:08:22Z

2

You need to access the element itself and take the value out of it. The result is a string.

function getnatega() {
    if (document.getElementById('txtjob').value === '2386') {
        window.location.href = "www.ex.com";
    }
}

<input type="text" id="txtjob">
<button onclick="getnatega()">OK</button>

answered May 22, 2016 at 7:08

Nina Scholz

388k26 gold badges367 silver badges417 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Asons · Accepted Answer · 2016-05-22 07:35:10Z

1

This is the correct code

<html>

<head>
<title>Test</title>
<script type="text/javascript">
function getnatega() 
{
  var a=document.getElementById('txtjob').value;

  if ( a == 2386) 
  {
    window.location.href = "www.ex.com";
  }
}
</script>
</head>
<body>

<input type="text" id="txtjob">
<button onclick="getnatega()">OK</button>


</body>
</html>

edited May 22, 2016 at 7:35

Asons

87.7k12 gold badges119 silver badges175 bronze badges

answered May 22, 2016 at 7:11

Jason

7863 gold badges16 silver badges36 bronze badges

2 Comments

ChevCast Over a year ago

Looks sound to me?

Asons Over a year ago

Since the result is string and you use non quoted 2386 it shouldn't, if to use ===, which I missed you didn't ... removed comment and down vote

ChevCast · Accepted Answer · 2016-05-22 07:15:09Z

0

You need to use the document API to get reference to the element in JavaScript. You can assign that element to a variable so you don't have to call the method every time.

var txtJob = document.getElementById('txtjob');
function getnatega() {
  if (txtJob.value == '2386') {
    window.location.href = "www.ex.com";
  }
}

There is a quirk in some browsers where the engine will define a global variable with the ID of the element. You may be able to get away with just if (window.txtjob.value == '2386') but even if it works I don't recommend using it because it's not a standardized behavior and all browsers may not do the same thing. All of them will have the document API though and you can use that to properly get reference to the element as shown above.

edited May 22, 2016 at 7:15

answered May 22, 2016 at 7:08

ChevCast

59.4k66 gold badges223 silver badges331 bronze badges

1 Comment

AhmedMah Over a year ago

Thanks, I appreciate your effort helping me.

Gabriel · Accepted Answer · 2016-05-22 07:08:15Z

0

Nothing happens because txtjob is undefined. If you want to get the input's value, it's in document.getElementById("txtjob").value.

answered May 22, 2016 at 7:08

Gabriel

2,1801 gold badge17 silver badges20 bronze badges

1 Comment

Gabriel Over a year ago

It is more than enough. Asker should do some work, I prefer to explain than to give code to copy and paste.

Collectives™ on Stack Overflow

JavaScript If statement issue

4 Answers 4

Comments

2 Comments

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

2 Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related