File upload form not valid

Question

I have a file upload form which I can not get to validate successfully. The form loads fine and I can upload a file but after 'submit' I can not get past Fileform.is_valid() in the view. I have mostly copies this view and the model and form model from the Django 1.9 File Uploads documentation but I must be missing something.

The view.py is,

def file_sharing_form(request):
if request.method == "POST":
    file = FileForm(request.POST, request.FILES)
    if file.is_valid():
        fform = file.save(commit=False)
        fform.author = request.user
        fform.pub_date = timezone.now()
        fform.submitted_date = timezone.now()
        fform.approved = False
        fform.save()
        # email admin
        admin_email = User.objects.all().filter(is_superuser = True)
        subject = 'File submitted to QQIresources, awaiting approval'
        to_email = admin_email[0].email
        from_email = request.user.email
        message = 'A file has been submitted to QQIresources by ' + str(request.user) + ' and is awaiting admin approval. \n \n Title: ' + str(fform.title) + '\n Author: ' + str(fform.author) + '\n Description: ' + str(fform.description)
        send_mail(subject, message, from_email, [to_email])
        return redirect('init')
fileform = FileForm()
return render(request, 'file_form.html', {'fileform': fileform})

I know the variable names are close but I think what I am using is correct Fileform = FileForm(.... Lower case 'f' for form in the first and uppercase 'F' in Form for the second. Thanks — ofey
– ofey, Commented May 30, 2016 at 16:09
I will change it to make them more distinct. But this is not the problem, thanks — ofey
– ofey, Commented May 30, 2016 at 16:13

binu.py · Accepted Answer · 2016-05-30 17:02:34Z

6

I guess you have missed enctype="multipart/form-data" in your html. Please add this in your form definition for any type of file upload.

<form action="{% url 'your_url' %}" enctype="multipart/form-data">
    <input type="file">
</form>

answered May 30, 2016 at 17:02

binu.py

1,2362 gold badges10 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

ofey Over a year ago

I did read about enctype="multipart/form-data" in the documentation but I thought it would be handles in the form. Obviously not, working now thanks

binu.py Over a year ago

You are Welcome :) @ofey

Collectives™ on Stack Overflow

File upload form not valid

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related