Using ng-hide on a loader in a directive in Angular

Question

I've been trying to replicate the loaing example on this page (Showing Spinner GIF during $http request in angular) by @punkrockpolly. But either the example is wrong or I'm not getting something.

Basically i have a directive

 .directive('loading', ['$http', function ($http) {
    var html = '<div class="loader" data-loading></div>';
    return {
      restrict: 'E',
      replace: true,
      template: html,
      link: function (scope, element, attrs) {

        console.log(element);

        scope.isLoading = function () {
            console.log("is loading");
          return $http.pendingRequests.length > 0;
        };

        scope.$watch(scope.isLoading, function (value) {
            console.log(value);
          if (value) {
            element.removeClass('ng-hide');
          } else {
            element.addClass('ng-hide');
          }
        });
      }
    };
}]);

That I'm trying to turn on or off based on the $http request.

Here's what I have on my HTML page

 <loading></loading>

What am I missing here.

Everything is fine, your example works. Try to add <div class="loader" data-loading></div> directly to your html and check if a spinner is showed up. — Simon Schüpbach
– Simon Schüpbach, Commented Jun 2, 2016 at 18:23
Really. I've been trying this same code for 30 mins and I can't get it to work. I just tried it again and nothing. Am I missing something? — Showcaselfloyd
– Showcaselfloyd, Commented Jun 2, 2016 at 18:26

Simon Schüpbach · Accepted Answer · 2016-06-02 18:29:43Z

2

Yes it works. I don't have the css for the spinner, but the ng-hidepart works perfect.

var app = angular.module('plunker', []);

app.controller('MainCtrl', function($scope) {
  $scope.name = 'World';
});
app.directive('loading', ['$http', function ($http) {
    var html = '<div class="loader" data-loading>test</div>';
    return {
      restrict: 'E',
      replace: true,
      template: html,
      link: function (scope, element, attrs) {

      
        scope.isLoading = function () {
      //      console.log("is loading");
          return $http.pendingRequests.length > 0;
        };
        
        // just to have some pending requests
        setInterval(function(){
           $http.get("https://www.google.com").then(function(){
       
           });
        },200)
       
        scope.$watch(scope.isLoading, function (value) {
       //     console.log(value);
          if (value) {
            element.removeClass('ng-hide');
          } else {
            element.addClass('ng-hide');
          }
        });
      }
    };
}]);

<!DOCTYPE html>
<html>

  <head>
    <meta charset="utf-8" />
    <title>AngularJS Plunker</title>
    <script>document.write('<base href="' + document.location + '" />');</script>
    <link href="style.css" rel="stylesheet" />
    <script data-semver="1.4.9" src="https://code.angularjs.org/1.4.9/angular.js" data-require="[email protected]"></script>
    <script src="app.js"></script>
  </head>

  <body ng-app="plunker" ng-controller="MainCtrl">
    <p>Hello {{name}}!</p>
    <loading></loading>
  </body>

</html>

answered Jun 2, 2016 at 18:29

Simon Schüpbach

2,6833 gold badges15 silver badges26 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Showcaselfloyd Over a year ago

Okay, thanks so much. I'll give it another shot. I really appreciate it!

Showcaselfloyd Over a year ago

Works. Thank you so much! StackExchange to the rescue once more!

gmuraleekrishna · Accepted Answer · 2016-06-02 19:14:12Z

1

To get app wide spinner use angular interceptors

angular.module("MyApp", ["ngResource"])

.config(function ($httpProvider) {
  $httpProvider.interceptors.push(function($q, $rootScope) {
    return {
      'request': function(config) {
          $rootScope.$broadcast('http:request:start');
          return config;
       },
       'response': function(response) {
          $rootScope.$broadcast('http:request:end');
          return $q.reject(response);
       }
     };
   });
 })

.directive('loading', ['$http', function ($http) {
    var html = '<div class="loader" data-loading></div>';
    return {
      restrict: 'E',
      replace: true,
      template: html,
      link: function (scope) {
        scope.isLoading = false;
        scope.$on('http:request:start', function() {
           scope.isLoading = true;
        });
        scope.$on('http:request:end', function() {
           scope.isLoading = false;
        });
      }
    };
}]);

edited Jun 2, 2016 at 19:14

answered Jun 2, 2016 at 18:28

gmuraleekrishna

3,4311 gold badge29 silver badges46 bronze badges

1 Comment

Showcaselfloyd Over a year ago

Okay, this might also work. I'll try that as well. Thanks for the feedback

Collectives™ on Stack Overflow

Using ng-hide on a loader in a directive in Angular

2 Answers 2

2 Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related