How to annotate dependencies in an inline controller while configuring app routes?

Question

I'm getting following error if I don't annotate the dependencies for an inline controller function for a route (I'm using strict DI mode and all other codes are annotated so that js-minification doesn't break my code):

https://docs.angularjs.org/error/$injector/strictdi?p0=function(AuthService,%20$state

Here is the logout route code:

app.config(['$stateProvider', '$urlRouterProvider', function($stateProvider', '$urlRouterProvider) {

  $stateProvider.state('logout', {
     url: '/logout',
     controller: function(AuthService, $state) {        
       AuthService.logout();
       $state.go('login');
     }
  }

}]);

Is there any technique to declare inline annotation for the above two dependent services (AuthService, $state) of the inline controller ?

I know the bellow work-around :

.state('logout', {
    url: '/logout',
    controller: LogoutController
});


function LogoutController (AuthService, $state) {        
    AuthService.logout();
    $state.go('login');
}
LogoutController.$inject = ['AuthService', '$state'];

this works but just wanted to checkout if anyone knows any smart short-cut ?

rrd · Accepted Answer · 2016-06-06 12:01:20Z

1

Try

app.config(['$stateProvider', '$urlRouterProvider', function($stateProvider, $urlRouterProvider) {
  $stateProvider.state('logout', {
     url: '/logout',
     controller: ['AuthService', '$state', function(AuthService, $state) {        
       AuthService.logout();
       $state.go('login');
     }]
  }
}]);

Not sure if that will work. Usually we separate our controllers into files for ease of use, rather than writing them inline in the config.route.js file.

answered Jun 6, 2016 at 12:01

rrd

5,9873 gold badges32 silver badges37 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Tushar Over a year ago

It worked ! Thanks a lot :) Didn't try that as I thought it would be an array syntax instead of function. You are right that controllers are separated out in separate files, but here I just have two lines of logic, so thought not to create overhead of processing another file.

rrd Over a year ago

Happy to have helped!

Tushar Over a year ago

Yeah, it will help many others too for sure. Thanks again for your time.

dchhetri · Accepted Answer · 2017-04-12 15:59:46Z

1

Just to add more details here, this is expected for inline controllers.

See https://github.com/olov/ng-annotate/issues/50.

Either not inline them or add apply controller: /* @ngInject */ function(service1){ ... }.

The /* @ngInject */ tells ngannotate to apply annotation here.

answered Apr 12, 2017 at 15:59

dchhetri

7,1766 gold badges45 silver badges57 bronze badges

Collectives™ on Stack Overflow

How to annotate dependencies in an inline controller while configuring app routes?

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related