Cannot read property 'indexOf' of undefined inside Angular Controller

Question

I'm having a problem with "Cannot read property 'indexOf' of undefined". Below are the source codes. Appreciate your help.

$http.get("js/project/data.json").then(function(response) {
        //$scope.case = response.data.caseno;    
        $scope.case = response.data.caseno.map(function(elem) { 
            return elem.toLowerCase(); 
        }); 
    });

    console.log($scope.project.ProjectCaseNo.toLowerCase());

    if($scope.case.indexOf($scope.project.ProjectCaseNo.toLowerCase()) != -1 ){
        $scope.glyphicon = 'glyphicon-ok green';
        $scope.CaseMessage = 'Valid Case No.';
    }else{
        $scope.glyphicon = 'glyphicon-remove red';
        $scope.CaseMessage = 'Invalid Case No.';
    };
};

Debug your code, find where the problem is, add the information to your question. Then we can try to help you. But the error is pretty self-explanatory. — emerson.marini
– emerson.marini, Commented Jun 8, 2016 at 8:41
Tip : JS is asynchronous. stackoverflow.com/questions/6847697/… — Jeremy Thille
– Jeremy Thille, Commented Jun 8, 2016 at 8:42

Jeremy Thille · Accepted Answer · 2016-06-08 08:45:21Z

2

change it something like this:

    $scope.VerifyCaseNo = function(){
        $http.get("js/project/data.json").then(function(response) {
            //$scope.case = response.data.caseno;    
            $scope.case = response.data.caseno.map(function(elem) { 
                return elem.toLowerCase(); 
            }); 
            console.log($scope.project.ProjectCaseNo.toLowerCase());

            if($scope.case.indexOf($scope.project.ProjectCaseNo.toLowerCase()) != -1 ){
                $scope.glyphicon = 'glyphicon-ok green';
                $scope.CaseMessage = 'Valid Case No.';
            }else{
                $scope.glyphicon = 'glyphicon-remove red';
                $scope.CaseMessage = 'Invalid Case No.';
            };
        });
    };

Your $scope.case will be undefined before the $http.get() operation is complete. so you get the Cannot read property 'indexOf' of undefined error!

edited Jun 8, 2016 at 8:45

Jeremy Thille

26.4k12 gold badges48 silver badges64 bronze badges

answered Jun 8, 2016 at 8:42

Abdel Raoof Olakara

19.4k11 gold badges92 silver badges134 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Mzach Over a year ago

Thanks guys for the solution. It's working as expected. Need to understand more on the $http concept.

Fangming Cheng · Accepted Answer · 2016-12-14 10:40:54Z

0

You can use String(yourValue).indexOf('')

answered Dec 14, 2016 at 10:40

Fangming Cheng

1711 silver badge4 bronze badges

2 Comments

beryllium Over a year ago

This does not provide an answer to the question. To critique or request clarification from an author, leave a comment below their post. - From Review

Petter Friberg Over a year ago

@beryllium seems like an attempt to answer to me

Collectives™ on Stack Overflow

Cannot read property 'indexOf' of undefined inside Angular Controller

2 Answers 2

1 Comment

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related