if statement makes my program in javascript stop working

Question

My code was working fine till I added the if statement. Any help is much appreciated.

function calc() {
   var a = parseInt(document.getElementById('eersteGetal').value); 
    var b = parseInt(document.getElementById('tweedeGetal').value); 
    var answer = parseInt(a + b);
    var quotient = a % b;
    var bigger = '';                                                
    if(a >= b) {                                
        bigger = "Number A is bigger";              
    } else if(a <= b) {                             
        bigger = "Number B is bigger";              
    } else(a === b) {                           
        bigger = "Number A en B are equal";     
    }
    var paragraaf = document.getElementById('answer'); 
    paragraaf.innerHTML = answer;
    var paragraafTwo = document.getElementById('quotient');  
    paragraafTwo.innerHTML = quotient;
    var paragraafThree = document.getElementById('bigger'); 
    paragraafThree.innerHTML = bigger;
}

if you want third condition then remove = from >= and <= — Madhawa Priyashantha
– Madhawa Priyashantha, Commented Jun 22, 2016 at 12:06
else is only exicuted if the other if/else if condition(s) do not return true so no condition is required for else. — NewToJS
– NewToJS, Commented Jun 22, 2016 at 12:07

Mohammad Usman · Accepted Answer · 2016-06-22 12:11:38Z

1

Remove condition from else part.

function calc() {
  var a = parseInt(document.getElementById('eersteGetal').value); 
  var b = parseInt(document.getElementById('tweedeGetal').value); 
  var answer = parseInt(a + b);
  var quotient = a % b;
  var bigger = '';                                                
  if(a > b) {                               
    bigger = "Number A is bigger";              
  } else if(a < b) {                          
    bigger = "Number B is bigger";              
  } else {
    bigger = "Number A en B are equal";     
  }
  var paragraaf = document.getElementById('answer'); 
  paragraaf.innerHTML = answer;
  var paragraafTwo = document.getElementById('quotient');  
  paragraafTwo.innerHTML = quotient;
  var paragraafThree = document.getElementById('bigger'); 
  paragraafThree.innerHTML = bigger;
}

<input type="text" id="eersteGetal">
<input type="text" id="tweedeGetal">
<button type="button" onclick="calc()">Calculate</button>
<p id="answer"></p>
<p id="quotient"></p>
<p id="bigger"></p>

answered Jun 22, 2016 at 12:11

Mohammad Usman

39.6k20 gold badges99 silver badges101 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Christiaan Erkelens Over a year ago

Thank you so much, removing the condition did the trick. Very greatful.

Jesper Højer · Accepted Answer · 2016-06-22 12:12:48Z

0

You cant put a condition in an ELSE.

Change your IF/ELSE-STATEMENT to this:

if(a > b ) {                               
    bigger = "Number A is bigger";              
}
else if(a < b) {                          
    bigger = "Number B is bigger";              
}
else {
    bigger = "Number A en B are equal";     
}

edited Jun 22, 2016 at 12:12

answered Jun 22, 2016 at 12:07

Jesper Højer

3,2221 gold badge18 silver badges26 bronze badges

3 Comments

Madhawa Priyashantha Over a year ago

last condition never reach

Jesper Højer Over a year ago

@FastSnail - Thanks for noticing.

Madhawa Priyashantha Over a year ago

remove = from first 2 conditions and add else

Dev · Accepted Answer · 2016-06-22 12:51:31Z

0

You Missed "if" in last else

else(a === b) {                            
bigger = "Number A en B are equal";     
}

it should be

else if(a === b) {                            
bigger = "Number A en B are equal";     
}

answered Jun 22, 2016 at 12:51

Dev

132 bronze badges

Collectives™ on Stack Overflow

if statement makes my program in javascript stop working

3 Answers 3

1 Comment

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related