powershell comparing string with -or

Question

I'm trying to verify the value of a variable, but no mater what, I can only get the right result if not using the -or

if (!$SER -eq "Y" -or  !$SER -eq "N"){
    write-host "ERROR: Wrong value for services restart" -foreground "red"
}

or like this

if (-not($SER -eq "Y") -or  -not($SER -eq "N")){
    write-host "ERROR: Wrong value for services restart" -foreground "red"
}

sodawillow · Accepted Answer · 2016-06-24 11:17:55Z

2

This works (ne stands for not equal):

if ($SER -ne "Y" -or $SER -ne "N") {
    Write-Host "ERROR: Wrong value for services restart" -ForegroundColor Red
}

This also works:

if ("Y", "N" -notcontains $SER) {
    Write-Host "ERROR: Wrong value for services restart" -ForegroundColor Red
}

And since PowerShell v3:

if ($SER -notin "Y", "N") {
    Write-Host "ERROR: Wrong value for services restart" -ForegroundColor Red
}

answered Jun 24, 2016 at 11:17

sodawillow

13.3k4 gold badges36 silver badges44 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2017-05-23 12:08:26Z

0

sodawillow provided a valid answer. Howevery, you can simplify this using -notin:

if ($SER -notin 'Y', 'N') {
    Write-Host "ERROR: Wrong value for services restart" -ForegroundColor Red
}

CommunityBot

11 silver badge

answered Jun 24, 2016 at 11:19

Martin Brandl

59.4k16 gold badges151 silver badges190 bronze badges