returning random int from method to array

Question

In my code i have static int method that should return an array of random integers. The problem is when i print an array, only the last number is random int, and other ints are all zeros.

static void Main(string[] args)
{
    int a = int.Parse(Console.ReadLine());
    int[] array = mtd(a);
    for (int i = 0; i < array.Length; i++)
    {
        Console.WriteLine(array[i]);
    }
}
public static int[] mtd(int b)
{
    int[] arr = new int[b];
    Array.Resize<int>(ref arr, b);
    Random rand = new Random();
    for (int i = 0; i < arr.Length; i++)
    {
        arr.SetValue(rand.Next(1, 5), arr.Length - 1);
    }
    return arr;
}

Did you set breakpoints, step through the code, inspect your variables and look at the documentation for Array.SetValue() so you can confirm that this code does what you expect it to? Hint: you're not using i... — CodeCaster
– CodeCaster, Commented Jun 27, 2016 at 6:58

diiN__________ · Accepted Answer · 2016-06-27 07:06:42Z

3

In the for loop in your method mtd you are always setting the last value of your array arr by using arr.Length - 1. Use i instead:

for (int i = 0; i < arr.Length; i++)
{
    arr[i] = rand.Next(1, 5);
}

Or with arr.SetValue:

for (int i = 0; i < arr.Length; i++)
{
    arr.SetValue(rand.Next(1, 5), i);
}

answered Jun 27, 2016 at 7:06

diiN__________

7,7197 gold badges49 silver badges74 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Adi543 Over a year ago

okay, i get it now, so the problem was my array.resize line. I was trying to use "i" but it could not work back then.

diiN__________ Over a year ago

You didn't need to use Array.Resize because you were setting the size of the array before when using new int[b].

Furtiro · Accepted Answer · 2016-06-27 07:15:05Z

0

Working one :

public static int[] mtd(int b)
    {
        int[] arr = new int[b];
        Random rand = new Random();
        for (int i = 0; i < arr.Length; i++)
        {
            arr.SetValue(rand.Next(1, 5), i);
        }
        return arr;
    }

EDIT : Btw the Array.resize is useless here, you already define the length of your array. ( new int[b] set the length of the array to b )

Your problem was that you never used i, so you just set the value of the last value of your array.

edited Jun 27, 2016 at 7:15

answered Jun 27, 2016 at 7:01

Furtiro

4495 silver badges21 bronze badges

Comments

user6438653 · Accepted Answer · 2016-06-27 07:23:56Z

0

I modified and simplified your code:

    public static int[] mtd(int b)
    {
        int[] arr = new int[b];
        Random rand = new Random();
        for (int i = 0; i < arr.Length; i++)
            arr[i] = rand.Next(1, 5);
        return arr;
    }

answered Jun 27, 2016 at 7:23

user6438653

2 Comments

Adi543 Over a year ago

arr[i] = rand.Next(1, 5) does look much better.

user6438653 Over a year ago

Thank you. @Adi543.

Collectives™ on Stack Overflow

returning random int from method to array

3 Answers 3

2 Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related