Javascript function does not run when called

Question

var gameFunction = function()
{
    var userChoice = prompt("What do you choose: rock, paper,   or scissors?")

    var computerChoice = Math.random();

    if (0 < computerChoice < 0.33)
    {
        computerChoice = "rock";
    }
    else if (0.33 < computerChoice < 0.67)
    {
        computerChoice = "scissors";
    }
    else
    {
        computerChoice = "paper";
    }

    console.log("Computer choice: ",computerChoice)

    if (userChoice === computerChoice)
    {
        return "The result is a tie! Enter a new result?"
        gameFunction();
    }

    else if (userChoice === "rock")
    {
        if (computerChoice === "scissors")
        {
            return "rock wins"
        }
        else if (computerChoice === "paper")
        {
        return "paper wins"
        }
    }

    else if (userChoice === "paper")
    {
        if (computerChoice === "rock")
        {
            return "paper wins"
        }
        else if (computerChoice === "scissors")
        {
            return "scissors win"
        }
    }

    else if (userChoice === "scissors")
    {
        if (computerChoice === "paper")
        {
            return "scissors wins"
        }
        else if (computerChoice === "rock")
        {
            return "rock win"
        }
    }
}

gameFunction();

This is the 9/9 section of the "Rock paper scissors" game from Codecademy: Javascript.

My problem is this:

When the User and Computer ties, it's supposed to re-run the entire "gameFunction" function, meaning it should ask a new input from the user and get a new input from the computer.

However, the program just prints out "The result is a tie!" without re-running "gameFunction." How can I fix this?

if (0 < computerChoice < 0.33) ==> if (0 < computerChoice && computerChoice < 0.33) — Tushar
– Tushar, Commented Jun 30, 2016 at 7:20
After return, no more code gets executed inside the function — Reeno
– Reeno, Commented Jun 30, 2016 at 7:21

Deepak Sharma · Accepted Answer · 2016-06-30 07:21:22Z

1

No line executed after return statement.. try

 gameFunction();
 return "The result is a tie! Enter a new result?"

answered Jun 30, 2016 at 7:21

Deepak Sharma

1,1471 gold badge12 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

nnnnnn Over a year ago

But then it will eventually display the result of the original tied game after the second game is finished. Wouldn't that confuse the player?

Deepak Sharma Over a year ago

u can give a delay by setTimeout function. depend upon your logic and requirements

user1567453 · Accepted Answer · 2016-06-30 07:26:25Z

1

The return statement exits the "gameFunction" function so it doesn't execute the next line. Try using a prompt instead like this:

if (userChoice === computerChoice)
{
    prompt("The result is a tie! Enter a new result?");
    gameFunction();
}

This way the user can respond to your prompt and you can use it to decide if the game is to continue. You could always just use an alert as well :)

answered Jun 30, 2016 at 7:26

user1567453

2,1632 gold badges20 silver badges22 bronze badges

Comments

Nguyen Tuan Anh · Accepted Answer · 2016-06-30 07:22:36Z

0

Change return to alert(), like below:

From:

return "The result is a tie! Enter a new result?"

To:

alert("The result is a tie! Enter a new result?");

answered Jun 30, 2016 at 7:22

Nguyen Tuan Anh

1,0358 silver badges14 bronze badges

Comments

Iván Rodríguez Torres · Accepted Answer · 2016-06-30 07:33:37Z

0

what about this: https://jsfiddle.net/41gcfL6g/

The thing here is adding a parameter to the function, so you can determine if have been a tie the last time you played. And then in the case of tie, instead of calling the function after the return, you return the result of the gameFunction

answered Jun 30, 2016 at 7:33

Iván Rodríguez Torres

4,4493 gold badges33 silver badges49 bronze badges

Comments

Saroj · Accepted Answer · 2016-06-30 07:35:43Z

0

The recusive gameFunction() method inside the gameFunction() because the control returns to the first calling function.

if (userChoice === computerChoice)
{
    return "The result is a tie! Enter a new result?"
    gameFunction();
}

So instead of return you can print a message there showing there is a tie.

if (userChoice === computerChoice)
{
    alert("The result is a tie! Enter a new result?")
    gameFunction();
}

and when the above condition is not met then it simply returns to the calling area and stop.

answered Jun 30, 2016 at 7:35

Saroj

1,5712 gold badges16 silver badges31 bronze badges

Comments

lordkain · Accepted Answer · 2016-06-30 07:38:27Z

see fiddle, don't use return, console.log https://jsfiddle.net/o62vda05/

var userChoice;

function startGame()
{
    userChoice = prompt("What do you choose: rock, paper,   or scissors?");
    gameFunction(); 
}

function gameFunction()
{
    var computerChoice = Math.random();

    if (0 < computerChoice < 0.33)
    {
        computerChoice = "rock";
    }
    else if (0.33 < computerChoice < 0.67)
    {
        computerChoice = "scissors";
    }
    else
    {
        computerChoice = "paper";
    }

    console.log("Computer choice: ",computerChoice)

    if (userChoice === computerChoice) {
        console.log( "The result is a tie! Enter a new result?");
        startGame();
    } else if (userChoice === "rock") {
        if (computerChoice === "scissors")
        {
            console.log( "rock wins");
        }
        else if (computerChoice === "paper")
        {
            console.log( "paper wins");
        }
    } else if (userChoice === "paper") {
        if (computerChoice === "rock") {
            console.log( "paper wins");
        } else if (computerChoice === "scissors") {
            console.log ("scissors win");
        }
    } else if (userChoice === "scissors") {
        if (computerChoice === "paper") {
            console.log ("scissors wins");
        } else if (computerChoice === "rock") {
            console.log( "rock win");
        }
    }
}

startGame();

Collectives™ on Stack Overflow

Javascript function does not run when called

6 Answers 6

2 Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

2 Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related