Make ASP.NET MVC Route Id parameter required

Question

I have this route:

routes.MapRoute(
            "PlaceDetails",
            "{controller}/{action}/{id}",
            new { controller = "Place", action = "Details", id = UrlParameter.Optional }
        );

This routes this fine: mysite.com/place/details/123

Making Id 123 available to the details action of the place controller - which can then lookup place '123'.

However - this URL is also passed to the controller: mysite.com/place/details/

I want this to return HttpNotFound - but it sends a null Id to the controller - and requires me to handle that.

It seems neater if the route itself achieves this rather than needing unseemly null checks in the controller itself.

I have found nothing in Google about this specific issue.

How can I do this?

For reference I now only use attribute routing - way more control, way easier to get your head round. — niico
– niico, Commented May 12, 2017 at 22:05

Community · Accepted Answer · 2017-05-23 12:17:55Z

10

To make the id value required, you must not set it as UrlParameter.Optional or provide any other default value. With no value in the URL segment, and no default, the route won't match the request.

routes.MapRoute(
    "PlaceDetails",
    "{controller}/{action}/{id}",
    new { controller = "Place", action = "Details" }
);

But you probably also need to constrain the route in another way to prevent it from matching in cases where it shouldn't.

routes.MapRoute(
    "PlaceDetails",
    "Place/{action}/{id}",
    new { controller = "Place", action = "Details" }
);

See Why map special routes first before common routes in asp.net mvc? for details and additional options.

edited May 23, 2017 at 12:17

CommunityBot

11 silver badge

answered Jul 2, 2016 at 16:25

NightOwl888

57.1k28 gold badges148 silver badges222 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Luke Girvin · Accepted Answer · 2018-09-20 10:38:43Z

3

Remove the optional for the id placeholder in the defaults

routes.MapRoute(
        "PlaceDetails",
        "{controller}/{action}/{id}",
        new { controller = "Place", action = "Details"}
    );

Now mysite.com/place/details/ will not match the route. Provided you don't have another default route mapped.

If the above causes conflicts with your routing you can modify it like this

routes.MapRoute(
        "PlaceDetails",
        "Place/Details/{id}",
        new { controller = "Place", action = "Details"}
    );

which couples this mapping directly to PlaceController.Details action

edited Sep 20, 2018 at 10:38

Luke Girvin

13.5k10 gold badges69 silver badges87 bronze badges

answered Jul 2, 2016 at 16:24

Nkosi

249k38 gold badges472 silver badges506 bronze badges

Collectives™ on Stack Overflow

Make ASP.NET MVC Route Id parameter required

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related