local variable might be not initialized before accessing c#

Question

So i try to get around this issue. I know for a fact that this will be initialized before am calling it but c# can not know this i guess. I cannot do xUser user = new xUser; One work around i was thinking about was using an List and store the values in list and then create the xuser after the while loop but it seems very messy. And i really wanna learn how to avoid this kind of errors.

        noUSer iuser = new noUSer();
        xUser user;
        string sql = "select * from accounts where id='" +id +"'";
        SQLiteCommand command = new SQLiteCommand(sql, m_dbConnection);
        SQLiteDataReader reader = command.ExecuteReader();

        while (reader.Read())
        {

            iuser.user_name = reader["login"].ToString();
            iuser.password = reader["password"].ToString();
            iuser.cookie_file = @"c:\cookies";

            user = iusers.create(iguser);


        }



        m_dbConnection.Close();
        if (tab_mode.SelectedTab.Text == "User")
        {
           dothiscall(user); //Error on "user" local variable might be not initialized before accessing

        }

Initialize it to null. However, you need to be aware that if loop doesn't execute, it will remain null. — Mehrzad Chehraz
– Mehrzad Chehraz, Commented Jul 3, 2016 at 2:08
Worked! Yes am aware of that. Thank you so much make it as an answer if you want. — Zara Rebecka Elisabeth Zentio
– Zara Rebecka Elisabeth Zentio, Commented Jul 3, 2016 at 2:12
Do you have a single user or multiple users? if so, with current implementation, you will call "dothiscall" only for the last one. — Mehrzad Chehraz
– Mehrzad Chehraz, Commented Jul 3, 2016 at 2:16
Possible duplicate of Why C# local variables must be initialized? — user12031933
– user12031933, Commented Nov 12, 2019 at 8:15

Mehrzad Chehraz · Accepted Answer · 2016-07-03 02:14:09Z

4

You should initialize the variable to null, however, be aware that if the code inside while loop doesn't execute, it will remain null.

answered Jul 3, 2016 at 2:14

Mehrzad Chehraz

5,1572 gold badges19 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

SilentCoder · Accepted Answer · 2016-07-03 02:13:48Z

0

Yes better way is create a list iusers and add new iuser inside while loop. and your whileloop to user you are adding iguser which can not find. It should be iuser

   xUser user = new xUser();
   string sql = "select * from accounts where id='" +id +"'";
   SQLiteCommand command = new SQLiteCommand(sql, m_dbConnection);
   SQLiteDataReader reader = command.ExecuteReader();

    while (reader.Read())
    {
        noUSer iuser = new noUSer();
        iuser.user_name = reader["login"].ToString();
        iuser.password = reader["password"].ToString();
        iuser.cookie_file = @"c:\cookies";

        user = iusers.Add(iuser);

    }

answered Jul 3, 2016 at 2:13

SilentCoder

1,9901 gold badge16 silver badges22 bronze badges

Comments

Niklas · Accepted Answer · 2016-07-03 03:07:02Z

0

When you do:

xUser user;

You are merely creating a pointer.meaning if u had an object of type xUser later on and wanted a pointer to it you could do for example something like :

user =(xUser)DataGridView1.Rows[0].cells[myxUserObjectInCell.index].Value;

That way making changes to user will make changes to the object in your grid. However if you're planning on creating an object of type xUser,then you need to do:

xUser user = new xUser();

The new keyword makes it initialize.

answered Jul 3, 2016 at 3:07

Niklas

1,01017 silver badges29 bronze badges

Collectives™ on Stack Overflow

local variable might be not initialized before accessing c#

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related