PHP if / if else statement not working as expected (Probably Simple)

Question

Ok, I am trying to do an IF / else IF statement that doesn't act as i would expect. I am trying to check that a URL address someone enters for certain things. The way I have done it is probably crap but I am not that good at programming.

All the IF parts work except for this bit if (strpos($URLcheck, "http://") == false)

It is supposed to check if the URL has http:// in it. But whether it does or doesn't it still acts exactly the same way.

I even tried forcing the http:// into the URL by stripping it of http:// or https://.

When I echo the variable ($URLcheck) , it shows the URL with the http://.....so why doesn't my code work? Thanks

    $URL = htmlspecialchars($_POST["URL"]);

    $URLREMOVESarray = array('https//:', 'http//:');
    $URLhttp = str_replace($URLREMOVESarray, "", $URL);

    $URLcheck = "http://" . $URLhttp;

    $URLsearchcheck2 = 'property-profile/';

    $URLsearchcheckDomain = "domain";


    if (strpos($URL, $URLsearchcheck2) !== false) {

   echo "Test 1";
   }
   else if (strpos($URLcheck, "http://") == false) {
   echo "Test 2";
   echo $URLcheck;
   }
   else if (strpos($URLcheck, $URLsearchcheckDomain) == false) {

   echo "Test 3";
   }
   else if (strpos($URLcheck, $URLsearchcheckDomain) == true) {
         Continue1();
   }

Update: Still no solutions to why this doesn't work? I have even copy and pasted the code from this page and it still doesn't work.

you're forcing a replacement of HTTPS domain prefix with a http prefix. This is not a good method — Mm-Art-In
– Mm-Art-In, Commented Jul 11, 2016 at 11:23
false equals 0 if you make comparisons without forcing the same type. Compare something with the same type with === or !== — Fredster
– Fredster, Commented Jul 11, 2016 at 11:25
thanks for the info, I tried all the alternatives == === !== and none of them worked for some reason — SuperBot12
– SuperBot12, Commented Jul 11, 2016 at 21:00

rokas · Accepted Answer · 2016-07-11 11:21:20Z

3

use the same !== false statement:

$URLcheck = 'http://www.google.com';
if (strpos($URLcheck, "http://") !== false) {
   echo "Test 2";
   echo $URLcheck;
}

answered Jul 11, 2016 at 11:21

rokas

1,5899 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

SuperBot12 Over a year ago

thanks for that code. i tried that myself but it didn't work. I can understand why

Jure Žitnik · Accepted Answer · 2016-07-11 12:16:42Z

2

strpos($URLcheck, "http://") searches for "http://" in the $URLcheck string and returns its position if it's found. In your case, it is indeed found at position 0 (start of $URLcheck string).

If strpos() doesn't find what it's looking for, it returns a false, which is not the same as 0, even though it sometimes seems so in PHP. This is the source of confusion for many less-experienced php devs, I advise to at least take a look at http://php.net/manual/en/types.comparisons.php

Anyway, in your case, the 0 that strpos returns is then checked if it equals false (with ==). But since 0 is an integer type and false is a boolean type, PHP has to convert the 0 to boolean and the best match for zero between true and false is obviously false. That's why your if statement behaves as it does, it's actually perfectly correct behaviour.

So what you need to do is check whether your strpos() output is identical to false instead of whether it equals it. You do this by simply adding another = to your condition, so it reads strpos($URLcheck, "http://") == false.

answered Jul 11, 2016 at 12:16

Jure Žitnik

794 bronze badges

1 Comment

SuperBot12 Over a year ago

thanks for the great explanation. I tried this code too but it also didn't work for me. Not sure what the problem is.

SuperBot12 · Accepted Answer · 2016-07-14 08:01:03Z

0

ok, nothing worked that I tried from the suggestions so I went with this code and it works. No idea why the other code wouldn't work

    $pos = strpos($URLhttp, 'example.com');

    if ($pos === false) {
    echo "Test 1";
    }

answered Jul 14, 2016 at 8:01

SuperBot12

778 bronze badges

Collectives™ on Stack Overflow

PHP if / if else statement not working as expected (Probably Simple)

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related