ASP.NET MVC Overriding Index action with optional parameter

Question

I want to accept /User/ and /User/213123

Where 213123 is a parameter (user_id)

Here is my RouteConfig.cs:

            routes.MapRoute(
                name: "user",
                url: "{controller}/{action}/{username}",
                defaults: new { controller = "User", action = "Index", username = UrlParameter.Optional }
            );

And my UserController.cs:

        public ActionResult Index()
        {
            ViewData["Message"] = "user index";
            return View();
        }

        [Route("user/{username}")]
        public ActionResult Index(string username)
        {
            ViewData["Message"] = "!" + username + "!";
            return View();
        }

This works in .net-core 1.0 but not in mvc5. What am I missing?

Thank you

EDIT:

Having just this in my UserController.cs also doesn't work (returns 404):

        public ActionResult Index(string username)
        {
            if (!String.IsNullOrEmpty(username))
            {
                ViewData["Message"] = "Hello " + username;
            }
            else
            {
                ViewData["Message"] = "user index";
            }

            return View();
        }

Description: HTTP 404. The resource you are looking for (or one of its dependencies) could have been removed, had its name changed, or is temporarily unavailable. Please review the following URL and make sure that it is spelled correctly.

Requested URL: /user/asd

EDIT2:

Updated RouteConfig.cs:

        routes.MapRoute(
            "userParam", "user/{username}",
          new { controller = "user", action = "IndexByUsername" },
          new { username = @"\w+" }
        );

        routes.MapRoute(
            name: "user",
            url: "user",
            defaults: new { controller = "User", action = "Index"}
        );

/User/ now calls IndexByUsername with Index as the username

/User/asd still returns 404

EDIT4: Current code:

RouteConfig.cs:

routes.MapRoute(
            name: "Default",
            url: "{controller}/{action}/",
            defaults: new { controller = "Home", action = "Index" }
        );
routes.MapRoute("userParam", "user/{username}", new { controller = "user", action = "Index"});
routes.MapRoute("user", "{controller}/{action}/{username}", new { controller = "User", action = "Index", username = UrlParameter.Optional });

UserController.cs:

public class UserController : Controller
{
    public ActionResult Index(string username)
    {
        if (!String.IsNullOrEmpty(username))
        {
            ViewData["Message"] = "Hello " + username;
        }
        else
        {
            ViewData["Message"] = "user index";
        }

        return View();
    }
}

You only need public ActionResult Index(string username) (and check if username is null or not) — user3559349
– user3559349, Commented Jul 14, 2016 at 9:47
Your url is /user/asd which tries to call the asd() method of userController - which does not exist hence the 404. It would need to be user/index/asd (or you can create a specific route for just /user/{username}) — user3559349
– user3559349, Commented Jul 14, 2016 at 9:56
"user/{username}" would need to be new { controller = "user", action = "Index" }, (not action = IndexByUsername). And for the second one, you just need the original route definition you had, or alternatively you could add username = UrlParameter.Optional to the userParam route and delete the user route — user3559349
– user3559349, Commented Jul 14, 2016 at 10:11

user3559349 · Accepted Answer · 2016-07-14 22:04:33Z

3

You need only one action method with the signature

public ActionResult Index(string username)

and in that method you can check if the value of username is null or not.

Then you route definitiosn needs to be (note the user route needs to be placed before the default route)

routes.MapRoute(
    name: "user",
    url: "user/{username}",
    defaults: new { controller = "User", action = "Index", username = UrlParameter.Optional }
);
routes.MapRoute(
    name: "Default",
    url: "{controller}/{action}/{id}",
    defaults: new { controller = "Home", action = "Index", id = UrlParameter.Optional }
);

answered Jul 14, 2016 at 22:04

user3559349

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

ASP.NET MVC Overriding Index action with optional parameter

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related