MySQL in PHP can't get values that are equal

Question

I'm trying to make a top users of my website, but the problem that I'm having is if one or more users have the same amount of won games only the first result appears on the website.

Im using this code to search in the database:

$rs1 = mysql_query(SELECT won,steamid,name,avatar,games 
   FROM `users` 
   WHERE won <> 0 
   GROUP BY won DESC LIMIT 18); 
while($row = mysql_fetch_array($rs1))
{ //AND HTML CODE HERE...}

Can someone help me with this? I want to show all the users for example if they have the same number of won games, for example it would show like:

RANK - USER - WON
1    - NAME - 12
2    - NAME - 8
3    - NAME - 8
4    - NAME - 4

BTW I know that I should not use mysql_query but I can't do it another way.

this is just the obligatory comment informing you that you shouldn't use mysql_* functions anymore. they are deprecated and, in php7, removed. use mysqli_* or PDO instead. — Franz Gleichmann
– Franz Gleichmann, Commented Jul 14, 2016 at 12:57

William Okano · Accepted Answer · 2016-07-14 12:47:13Z

1

I don't think you need the group by clause, but if you do, please consider using all the projection fields on group by. Although mysql allows you to group by different fields, it's not a good practice to do so.

answered Jul 14, 2016 at 12:47

William Okano

3921 gold badge3 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

svn · Accepted Answer · 2016-07-14 12:57:30Z

0

Seems to me that your GROUP BY should be an ORDER BY

rs1 = mysql_query(SELECT won,steamid,name,avatar,games 
               FROM `users` 
               WHERE won <> 0 
               ORDER BY won DESC LIMIT 18);

If that does not work please share the table structure

answered Jul 14, 2016 at 12:57

svn

1,41812 silver badges24 bronze badges

Comments

Mahesh Madushanka · Accepted Answer · 2016-07-14 13:00:06Z

0

Add name in to Group by clause

SELECT won,steamid,name,avatar,games FROM users WHERE won <> 0 
GROUP BY won,name order by won,name DESC LIMIT 18

edited Jul 14, 2016 at 13:00

answered Jul 14, 2016 at 12:45

Mahesh Madushanka

3,0032 gold badges17 silver badges29 bronze badges

4 Comments

Mario.C Over a year ago

Well there is just one problem solved... now im getting all the users bet they are not ordered from the one who have more won games

RiggsFolly Over a year ago

Excuse my ignorance but dont you need a ORDER BY something DESC

Mario.C Over a year ago

@RiggsFolly thanks i just replaced the GROUP by ORDER and it's done.

Mahesh Madushanka Over a year ago

@RiggsFolly Updated query

Collectives™ on Stack Overflow

MySQL in PHP can't get values that are equal

3 Answers 3

Comments

Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related