Function in Angular factory is undefined

Question

I have the following preloader.js factory file included in my project.

    angular.module('movieSeat')
        .factory('preloader', function( $q, $rootScope ) {

In my controller I inject the factory as following:

    angular.module('movieSeat')
        .controller('moviesearchCtrl', ['$scope', 'moviesearchFactory', function ($scope, moviesearchFactory, preloader) {

When I try to use the preloadImages function inside the preload controller:

    $scope.imageLocations = [
        "https://image.tmdb.org/t/p/w300_and_h450_bestv2//nlqFgG7jfBITl8fJHzL72jXwYLt.jpg",
        "https://image.tmdb.org/t/p/w300_and_h450_bestv2//ghL4ub6vwbYShlqCFHpoIRwx2sm.jpg",
        "https://image.tmdb.org/t/p/w300_and_h450_bestv2//weUSwMdQIa3NaXVzwUoIIcAi85d.jpg",
    ];

    preloader.preloadImages($scope.imageLocations)

I get the following error:

Cannot read property 'preloadImages' of undefined

If I comment out the preloader.preloadImages($scope.imageLocations) code the error is gone. So to me it looks like injecting the preloader factory in my controller works fine but I can't figure out why I can't call the function preloadImages on the preload factory.

show us the preloadImages function

Sajeetharan
– Sajeetharan

2016-07-18 10:40:58 +00:00
Commented Jul 18, 2016 at 10:40 — Sajeetharan
– Sajeetharan, Commented Jul 18, 2016 at 10:40

Tarun Dugar · Accepted Answer · 2016-07-18 10:42:29Z

2

There's a typo in the dependency injection list. You forgot to add preloader in the list of dependency strings.

 .controller('moviesearchCtrl', ['$scope', 'moviesearchFactory', 'preloader' /*here*/, function ($scope, moviesearchFactory, preloader) {

answered Jul 18, 2016 at 10:42

Tarun Dugar

8,9938 gold badges50 silver badges81 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Arielle Nguyen · Accepted Answer · 2016-07-18 10:44:10Z

1

You need to reference your factory/service 'preloader' in your controller call as follows:

angular.module('movieSeat')
        .controller('moviesearchCtrl', ['$scope', 'moviesearchFactory', 'preloader', function ($scope, moviesearchFactory, preloader) {

})

answered Jul 18, 2016 at 10:44

Arielle Nguyen

3,1721 gold badge22 silver badges16 bronze badges

Collectives™ on Stack Overflow

Function in Angular factory is undefined

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related