Is accessing static variables inside a non-static function considered bad coding?

Question

Here is an example that I am working on, and didn't know if it was considered bad coding?

class CounterClass
{
    private $counter = 0;
    static $counterOverall = 0;

   function CountUp()
   {
      $this->$counter++;
      self::$counterOverall++;
   }

}

TerraPass · Accepted Answer · 2016-07-25 10:41:58Z

1

No.

There is nothing inherently "bad" about accessing static variables from non-static methods. By itself, it's a perfectly acceptable practice.

Like most things in software engineering, it's just a tool, which can sometimes be perfect for a job at hand, while being a poor choice in other cases. It's up to the programmer to decide when best to use it.

answered Jul 25, 2016 at 10:41

TerraPass

1,60212 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

pioneer · Accepted Answer · 2016-07-25 10:44:36Z

0

I don't see any good reason to categorize this code under the "bad" category. Using static is giving you a shared memory across all instances of your class, which is just what you need in this case. I hope this helps!

answered Jul 25, 2016 at 10:44

pioneer

1035 bronze badges

Collectives™ on Stack Overflow

Is accessing static variables inside a non-static function considered bad coding?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related