Recursive function not returning a value in PHP

Question

I've got a recursive function defined as follows

private function _buildPathwayRecurse(&$category, &$reversePathway = array()) {
  $category->uri = FlexicontentHelperRoute::getCategoryRoute($category->id);
  $reversePathway[] = $category;

  if ($category->parent_id != 0) {
    $category = $this->_getCatForPathway($category->parent_id);
    $this->_buildPathwayRecurse($category, $reversePathway);
  } else {
    return $reversePathway;
  }
}

and I'm calling it like so

$reversePathway = $this->_buildPathwayRecurse($category);

However $reversePathway ends up being null. Any idea why that is? I've stepped through my code using XDebug and as far as I can tell everything works as it should. When I get to the line

return $reversePathway

$reversePathway looks perfect. It's persisting through the function calls and gaining a new item each time. right before executing the return line it's got an array of a few items just like it should be, but by the time I get out to

$reversePathway = $this->_buildPathwayRecurse($category);

it seems to just dissapear!

You overwrite the variable in the second line of the function. That happens in every recursion. — halfdan
– halfdan, Commented Oct 4, 2010 at 16:13

Jas · Accepted Answer · 2011-10-06 23:45:25Z

6

You are missing a return statement. try

private function _buildPathwayRecurse(&$category, &$reversePathway = array()) {
$category->uri = FlexicontentHelperRoute::getCategoryRoute($category->id);
$reversePathway[] = $category;

if ($category->parent_id != 0) {
$category = $this->_getCatForPathway($category->parent_id);
return $this->_buildPathwayRecurse($category, $reversePathway); //no assignment,     the     function will be executed but even if the inner part goes to the else block, there's nothing to hold the returned value.
//nothing to return when it gets here.
  } else {
    return $reversePathway;
  }
}

answered Oct 6, 2011 at 23:45

Jas

611 silver badge1 bronze badge

Sign up to request clarification or add additional context in comments.

Comments

Spudley · Accepted Answer · 2010-10-04 16:22:47Z

4

The if() block tells it to either recurse or return a value.

The first iteration will obviously recurse, so it won't do the return, so all your hard work building the array will not be returned out of the initial iteration.

You probably want it to return either way, rather than having an else clause.

answered Oct 4, 2010 at 16:22

Spudley

169k39 gold badges240 silver badges309 bronze badges

Comments

Ruel · Accepted Answer · 2010-10-04 16:15:39Z

3

Your if block is missing a return statement.

private function _buildPathwayRecurse(&$category, &$reversePathway = array()) {
  $category->uri = FlexicontentHelperRoute::getCategoryRoute($category->id);
  $reversePathway[] = $category;

  if ($category->parent_id != 0) {
    $category = $this->_getCatForPathway($category->parent_id);
    $this->_buildPathwayRecurse($category, $reversePathway); //no assignment, the function will be executed but even if the inner part goes to the else block, there's nothing to hold the returned value.
    //nothing to return when it gets here.
  } else {
    return $reversePathway;
  }
}

answered Oct 4, 2010 at 16:15

Ruel

15.8k7 gold badges41 silver badges49 bronze badges

1 Comment

mickmackusa Over a year ago

Your answer is also missing a return in the if block. Does is need an array_merge() or push too?

Collectives™ on Stack Overflow

Recursive function not returning a value in PHP

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related