C# reference parameter usage

Question

I'm using reference parameter for returning multiple information. like,

int totalTransaction = 0;
int outTransaction = 0;
int totalRecord = 0;

var record = reports.GetTransactionReport(searchModel, out totalTransaction, out outTransaction, out totalRecord);

// and the method is like this,

public List<TransactionReportModel> GetAllTransaction(
            TransactionSearchModel searchModel, 
            out totalTransaction,
            out totalTransaction,
            out totalRecord) {


    IQueryable<TransactionReportModel> result;
    // search

    return result.ToList();
}

But I don't like the long parameters, so I'm trying to cleaning that up with single parameter, using Dictionary.

Dictionary<string, int> totalInfos = new Dictionary<string, int>
{
    { "totalTransaction", 0 },
    { "outTransaction", 0 },
    { "totalRecord", 0 }
};

var record = reports.GetTransactionReport(searchModel, out totalInfos);

But still not good enough, because the key strings are not promised, it's like hard cording.

Do I need to use Constant for the keys? or any better solution for that case?

Although not all of these warnings matter, I do agree with this one: msdn.microsoft.com/en-us/library/ms182131.aspx Unless you really understand why you need an out parameter I would avoid them. — starlight54
– starlight54, Commented Jul 30, 2016 at 15:15

Eli Arbel · Accepted Answer · 2016-07-30 15:14:52Z

5

Just use a class. And avoid out parameters completely:

class TransactionResult
{
    public List<TransactionReportModel> Items { get; set; }

    public int TotalTransaction { get; set; }
    public int OutTransaction { get; set; }
    public int TotalRecord { get; set; }
}


public TransactionResult GetAllTransaction(TransactionSearchModel searchModel)
{
    IQueryable<TransactionReportModel> result;
    // search

    return new TransactionResult
    { 
        Items = result.ToList(),
        TotalTransaction = ...,
        OutTransaction = ...,
        TotalRecord = ...
    };
}

answered Jul 30, 2016 at 15:14

Eli Arbel

22.8k3 gold badges48 silver badges73 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

C# reference parameter usage

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related